Skip to content

Report search outcomes and diagnostics in JSON output - #41

Merged
DanielThomas merged 1 commit into
mainfrom
fix/json-diagnostics
Nov 11, 2026
Merged

DanielThomas merged 1 commit into
mainfrom
fix/json-diagnostics

Conversation

@DanielThomas

Copy link
Copy Markdown
Member

Summary

  • Extend the streaming version 1 JSON envelope with exitCode and diagnostics, retaining partial results.
  • Distinguish absent query targets (not_found) from invalid queries and search failures (error), independently of exit status.
  • Preserve existing stderr and exit-code behavior and document the protocol boundary for argument-parsing errors.

This supplies the structured outcome needed to address the lost results reported in Netflix/ja#131.

Validation

  • Added failing regression tests before implementation.
  • Full suite: 325 tests passed, including 9 JSON outcome tests.
  • git diff --check passes.

@DanielThomas
DanielThomas merged commit 88b743c into main Nov 11, 2026
1 check passed
@DanielThomas
DanielThomas deleted the fix/json-diagnostics branch November 11, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant