Repository navigation
Fix import binding preservation and comment formatting - #29
Merged
Merged
Conversation
Respect explicit type imports when expanding wildcards and retain used java.lang imports to avoid changing type bindings. Stabilize comment-only blocks, align tabular array closing braces, and preserve line-comment markers in flat layouts. Add regression coverage, including compiled field-type checks, and record the fixes in the vendor patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix correctness issues identified while reviewing Guillaume Laforge's formatter comparison, plus an additional import-binding defect found during reproduction.
java.lang.Threadto a wildcard-importedcustom.Threadwhile leaving the result compilable.java.langimports instead of unconditionally removing them. Removing them can introduce ambiguity or change bindings; unused imports are still removed.Formatting did not convergefailure without changing forced-break width accounting.$NON-NLS$and suppression markers, consistently with the existing no-reflow policy.Validation
Regression tests were added before the fixes and reproduced the reported failures. Coverage includes comment-only methods, constructors, initializers, type declarations, control-flow blocks and lambdas; array comments with and without trailing commas; and standalone JBang directives and trailing comment markers.
Import regression tests compile source before and after formatting and inspect the resulting field type for ordinary and static wildcard imports.
ja test --all: 221 tests passedgit diff --check: cleanScope
No changes to structural wrapping policy are included. The style-evaluation document is excluded from this PR. Pre-existing drift between the vendor patch and the integrated visitor source is not reconciled here; this change adds only the correctness fixes to that patch.