Skip to content

Preserve partial insight results and report scope failures - #133

Merged
DanielThomas merged 1 commit into
mainfrom
fix/insight-json-diagnostics
Nov 11, 2026
Merged

DanielThomas merged 1 commit into
mainfrom
fix/insight-json-diagnostics

Conversation

@DanielThomas

Copy link
Copy Markdown
Member

Summary

  • Update the bundled jist from 0.6.16 to published 0.6.17, including the hash refreshed by ja require.
  • Consume structured JSON outcomes on nonzero provider exits, retain partial result rows, and report actual scope failures even when another context succeeds.
  • Distinguish absent targets from invalid queries and search failures instead of treating exit code 1 as universally absent. Keep all-absent declaration searches successful and empty.
  • Use JSON for the global implementation lookup as well; retain original diagnostics when output is absent or malformed.

Addresses the silent failure and lost partial results reported in #131 (comment). This does not fix the underlying optional JdbcOperations resolution failure or retry failed inputs; partial searches are now explicitly unsuccessful.

Validation

  • Added deterministic failing regression tests before implementation, including a failed shared-input owner alongside an empty successful context.
  • Built native launchers and a local validation distribution using published jist 0.6.17.
  • Ran the full suite using that newly built distribution: 609 tests found, 3 skipped, 606 passed.
  • Ran the public Gradle 9.1.0 / Spring Security 7.1.1 reproducer five times: every run exited 2, reported JdbcOperations, and retained four or five partial caller rows.
  • git diff --check passes.

The jist release workflow completed successfully before the dependency update: https://github.com/Netflix/jist/releases/tag/v0.6.17.

@DanielThomas
DanielThomas merged commit c83999a into main Nov 11, 2026
12 checks passed
@DanielThomas
DanielThomas deleted the fix/insight-json-diagnostics branch November 11, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant