Repository navigation
Preserve module patches when compiling benchmark harnesses - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jmhlisting, selector discovery, andbench --check.Validation
ja0.26.24: run a benchmark, add another benchmark class, then runbench --checkagain. The resolved invocation includes the new class in--patch-module, but harness compilation previously reportedcannot find symbol.Release coordination
This is the provider phase of a two-release sequence. Release this fix as
v0.26.25, verifycom.netflix.tools.jmh@0.26.25on Maven Central, then update the client provider pin and releasev0.26.26. Keep the existing 0.26.23 pin until the new provider is published.