This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(source): change href type to str and add URL validation#6012
Closed
whitdog47 wants to merge 1 commit into
Closed
fix(source): change href type to str and add URL validation#6012whitdog47 wants to merge 1 commit into
whitdog47 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors URL handling for the Link model by switching the href type from AnyHttpUrl to str and adding an API layer validation mechanism using Pydantic.
- Update of the Link model in models.py to use str for href with a comment noting the change for JSON serialization.
- Introduction of a LinkValidator and an all_links_are_valid function in service.py for URL validation before database persistence.
- Minor adjustments in error handling in get_by_name_or_raise for missing sources.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/data/source/service.py | Added URL validation logic, logging for invalid URLs, and updated error handling in source retrieval. |
| src/dispatch/data/source/models.py | Changed the Link.href type from AnyHttpUrl to str and updated inline documentation about URL validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Linkmodel to address issues related to JSON serialization. The primary changes involve replacing theAnyHttpUrltype withstrin the SQLAlchemy model and implementing a robust validation mechanism at the API layer to ensure URLs are valid before being persisted to the database.Key Changes
Model Update:
hreffield type fromAnyHttpUrltostrin theLinkSQLAlchemy model.AnyHttpUrlcannot be directly serialized to JSON, and the list ofLinkobjects are stored as JSON in thesourcetable.Validation Mechanism:
AnyHttpUrlto validate URLs before they are stored in the database.