Repository navigation
Partial reloads 22: Disable experimental reloads by default - #2308
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The partial-reload stack enabled sv_neo_reload_experimental while it was reviewed. Set the default back to 0 so the original reload behavior stays unless a server opts in.
sunzenshen
force-pushed
the
stack/reload-zr68c/160-mx
branch
from
November 10, 2026 02:11
dddde5c to
bd8a5bb
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/170-flag-off
branch
from
November 10, 2026 02:11
5582e1f to
94fae98
Compare
This was referenced Nov 10, 2026
This was referenced Nov 13, 2026
Closed
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial reloads 22: set the default of
sv_neo_reload_experimentalback to 0. This PR builds on layer 21 (#2307, theMX family). It has no neoAssets pair.
Layer 06 (#2293) set the default to 1 while the stack is reviewed, so reviewers could test without setting the cvar,
and marked it with a
// NEO TODO:. This PR undoes that: the default is 0 and the TODO is gone. The flag line isthen the same as in #2293's feature commit.
With the flag at 0, every gun behaves as on master. Each layer's PR shows that case in its results ("flag 0").
How to review
weapon_neobasecombatweapon.cpp: the default changes from"1"to"0"; the two-line TODO comment is removed.How to test
behavior (the reload starts over, no
+1).sv_neo_reload_experimental 1and load a map: the partial reloads of layers 06-21 are back.Results
Layer 22 build (this PR + neoAssets layer 21), Linux Debug,
ntre_engage_ctg:sv_neo_reload_experimental= 0draw, thenreloadfrom the start, 30 roundssv_neo_reload_experimental 1before the map loads: the same stepsdrawunloaded_reloadresume, 30 at +1.25 s from the drawmatch_end=True, 0 assertsToolchain
Linked Issues