Skip to content

Partial reloads 22: Disable experimental reloads by default - #2308

Closed
sunzenshen wants to merge 1 commit into
stack/reload-zr68c/160-mxfrom
stack/reload-zr68c/170-flag-off
Closed

sunzenshen wants to merge 1 commit into
stack/reload-zr68c/160-mxfrom
stack/reload-zr68c/170-flag-off

Conversation

@sunzenshen

@sunzenshen sunzenshen commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Partial reloads 22: set the default of sv_neo_reload_experimental back to 0. This PR builds on layer 21 (#2307, the
MX family). It has no neoAssets pair.

Layer 06 (#2293) set the default to 1 while the stack is reviewed, so reviewers could test without setting the cvar,
and marked it with a // NEO TODO:. This PR undoes that: the default is 0 and the TODO is gone. The flag line is
then the same as in #2293's feature commit.

With the flag at 0, every gun behaves as on master. Each layer's PR shows that case in its results ("flag 0").

How to review

  1. weapon_neobasecombatweapon.cpp: the default changes from "1" to "0"; the two-line TODO comment is removed.

How to test

  1. Load a map with no cvar set. Take the ZR68C, reload, switch after the magazine is out, switch back: master
    behavior (the reload starts over, no +1).
  2. Set sv_neo_reload_experimental 1 and load a map: the partial reloads of layers 06-21 are back.

Results

Layer 22 build (this PR + neoAssets layer 21), Linux Debug, ntre_engage_ctg:

case result
no cvar set sv_neo_reload_experimental = 0
ZR68C, no cvar: dry reload, switch to the secondary after the magazine is out, back master: plain draw, then reload from the start, 30 rounds
ZR68C, sv_neo_reload_experimental 1 before the map loads: the same steps drawunloaded_reload resume, 30 at +1.25 s from the draw
headless TDM, 12 bots, no cvar set, 1 round PASS, match_end=True, 0 asserts

Toolchain

  • Linux GCC Distro Native (Linux Mint 22.3, GCC 13.3.0)

Linked Issues

The partial-reload stack enabled sv_neo_reload_experimental while it
was reviewed. Set the default back to 0 so the original reload
behavior stays unless a server opts in.
@sunzenshen
sunzenshen force-pushed the stack/reload-zr68c/160-mx branch from dddde5c to bd8a5bb Compare November 10, 2026 02:11
@sunzenshen
sunzenshen force-pushed the stack/reload-zr68c/170-flag-off branch from 5582e1f to 94fae98 Compare November 10, 2026 02:11
@sunzenshen sunzenshen changed the title Partial reloads 19: Disable experimental reloads by default Partial reloads 22: Disable experimental reloads by default Nov 10, 2026
@sunmachine sunmachine added the Animations Animation stuff. Including the syncronizing of animations between client and server based on state. label Nov 12, 2026
@sunzenshen

Copy link
Copy Markdown
Contributor Author

Closing to clear the board in favor of the PR stack of sunzenshen#34

@sunzenshen sunzenshen closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Animation stuff. Including the syncronizing of animations between client and server based on state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants