Repository navigation
Partial reloads 16: Add partial reloads to the PZ252 - #2302
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The PZ252 script gets the reload phases from neoAssets and a chamber
slot: #base "weapon_pz_reload_phases.txt", "ReloadPhases" {} and
"ChamberedRound" "1", and game_sounds_weapons.txt the six reload sound
pieces the phases play (weapon_pz.reload_unload, reload_unload_part2,
reload_load, reload_load_part2, reload_load_part3, reload_cycle). The
generic phase code then resumes a reload interrupted after the unload
or the load, and a reload with a round chambered skips the slide
pull. No code changes.
This was referenced Nov 9, 2026
sunzenshen
force-pushed
the
stack/reload-zr68c/100-srs
branch
from
November 10, 2026 02:10
31c04bd to
cf239c9
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/110-pz252
branch
from
November 10, 2026 02:10
8bed0f6 to
eefc82a
Compare
This was referenced Nov 13, 2026
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on NeotokyoRebuild/neoAssets#188 (layer 16: the PZ252 sources, clips, phases file and sound pieces).
Partial reloads 16: add partial reloads to the PZ252. This PR builds on layer 15 (#2301, the SRS) and pairs with
neoAssets layer 16. Next: #2303 (17, MPN45 family).
The phase code of 03-05 is generic: a weapon gets partial reloads from its weapon script and a phases file. This PR
adds the weapon script lines and the sound entries; it has no code changes.
#base "weapon_pz_reload_phases.txt","ReloadPhases" {},"ChamberedRound" "1", as the ZR68C hasthem. Its reload has three steps (drum out, drum seat, slide) and six new sound entries,
weapon_pz.reload_unload,_unload_part2,_load,_load_part2,_load_part3,_cycle.sv_neo_reload_experimentaldefaults to 1 while the partial-reload stack is reviewed (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293); thelast PR of the stack sets it back to 0. With the flag at 0 the PZ252 behaves as on master.
How to review
weapon_pz.txt: the three lines, asweapon_zr68c.txthas them (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293, Partial reloads 08: Keep a chambered round through a partial reload #2294).game_sounds_weapons.txt: the six PZ252 entries, in theweapon_zr68.reload_*pattern.How to test
100+1.100+1. Fire the drum empty and reload: 100 with a dim round icon,then
99+1at the slide.with a round chambered. Then once dry after the new drum is seated (about 4.1-5.3 s in).
sv_neo_reload_experimental 0(set before the map loads): master behavior, 100 rounds, no+1.Results
Layer 16 build (this PR + neoAssets layer 16), Linux Debug,
ntre_engage_ctg, owner PZ252 plus abot_mimicbot:reload_skipcycle: 1 at the unload (+1.44 s) -> 101 (100+1) at the load (+4.04 s), ends +5.15 s after the latch; two unload and three load sounds once each; no slide pullreload: 0 -> 100 with the round icon dim (+4.04 s) -> 99+1 at the slide (+5.37 s)drawunloaded_reload: 0 -> 100 (+3.05 s) -> 99+1 (+4.38 s); three load sounds and the cycle sounddrawunloaded_reload_skipcycle: 1 -> 101 (+3.05 s)drawtocycle_reload: 100 dim -> 99+1 (+1.61 s); cycle sounddraw, 101 keptreload50 -> 100 and 0 -> 100 at +5.24 s, whole soundmatch_end=True, 0 asserts; bots kept their reloads past the drum out (round chambered, clip 1)Toolchain
Linked Issues