Skip to content

Partial reloads 16: Add partial reloads to the PZ252 - #2302

Closed
sunzenshen wants to merge 1 commit into
stack/reload-zr68c/100-srsfrom
stack/reload-zr68c/110-pz252
Closed

sunzenshen wants to merge 1 commit into
stack/reload-zr68c/100-srsfrom
stack/reload-zr68c/110-pz252

Conversation

@sunzenshen

@sunzenshen sunzenshen commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Depends on NeotokyoRebuild/neoAssets#188 (layer 16: the PZ252 sources, clips, phases file and sound pieces).

Partial reloads 16: add partial reloads to the PZ252. This PR builds on layer 15 (#2301, the SRS) and pairs with
neoAssets layer 16. Next: #2303 (17, MPN45 family).

The phase code of 03-05 is generic: a weapon gets partial reloads from its weapon script and a phases file. This PR
adds the weapon script lines and the sound entries; it has no code changes.

  • PZ252: #base "weapon_pz_reload_phases.txt", "ReloadPhases" {}, "ChamberedRound" "1", as the ZR68C has
    them. Its reload has three steps (drum out, drum seat, slide) and six new sound entries, weapon_pz.reload_unload,
    _unload_part2, _load, _load_part2, _load_part3, _cycle.
  • The flag sv_neo_reload_experimental defaults to 1 while the partial-reload stack is reviewed (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293); the
    last PR of the stack sets it back to 0. With the flag at 0 the PZ252 behaves as on master.

How to review

  1. weapon_pz.txt: the three lines, as weapon_zr68c.txt has them (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293, Partial reloads 08: Keep a chambered round through a partial reload #2294).
  2. game_sounds_weapons.txt: the six PZ252 entries, in the weapon_zr68.reload_* pattern.
  3. The neoAssets layer 16 phases file.
  4. Test in game: "How to test".

How to test

  1. Load a map (the flag is 1 by default during review). Take the PZ252 (Support, Lieutenant): the HUD shows 100+1.
  2. Fire some rounds and reload: no slide pull, 100+1. Fire the drum empty and reload: 100 with a dim round icon,
    then 99+1 at the slide.
  3. Reload and switch to the secondary after the old drum is out (about 1.5-4.0 s in), then back, once dry and once
    with a round chambered. Then once dry after the new drum is seated (about 4.1-5.3 s in).
  4. Repeat with sv_neo_reload_experimental 0 (set before the map loads): master behavior, 100 rounds, no +1.

Results

Layer 16 build (this PR + neoAssets layer 16), Linux Debug, ntre_engage_ctg, owner PZ252 plus a bot_mimic bot:

case result
tactical from 50 (49+1) reload_skipcycle: 1 at the unload (+1.44 s) -> 101 (100+1) at the load (+4.04 s), ends +5.15 s after the latch; two unload and three load sounds once each; no slide pull
dry from 0 reload: 0 -> 100 with the round icon dim (+4.04 s) -> 99+1 at the slide (+5.37 s)
dry, switch after the unload, back drawunloaded_reload: 0 -> 100 (+3.05 s) -> 99+1 (+4.38 s); three load sounds and the cycle sound
tactical, switch after the unload, back drawunloaded_reload_skipcycle: 1 -> 101 (+3.05 s)
dry, switch after the load, back drawtocycle_reload: 100 dim -> 99+1 (+1.61 s); cycle sound
tactical, switch after the load, back plain draw, 101 kept
flag 0: tactical, dry master: reload 50 -> 100 and 0 -> 100 at +5.24 s, whole sound
HUD (frame crops) tactical: round icon lit throughout, row lit -> dim at the unload -> lit; dry: icon dim with the row dim and with the row lit after the load, lit at 99+1
headless TDM, 12 Support bots on the PZ252, flag 1, 1 round PASS, match_end=True, 0 asserts; bots kept their reloads past the drum out (round chambered, clip 1)

Toolchain

  • Linux GCC Distro Native (Linux Mint 22.3, GCC 13.3.0)

Linked Issues

The PZ252 script gets the reload phases from neoAssets and a chamber
slot: #base "weapon_pz_reload_phases.txt", "ReloadPhases" {} and
"ChamberedRound" "1", and game_sounds_weapons.txt the six reload sound
pieces the phases play (weapon_pz.reload_unload, reload_unload_part2,
reload_load, reload_load_part2, reload_load_part3, reload_cycle). The
generic phase code then resumes a reload interrupted after the unload
or the load, and a reload with a round chambered skips the slide
pull. No code changes.
@sunzenshen

Copy link
Copy Markdown
Contributor Author

Closing to clear the board in favor of the PR stack of sunzenshen#34

@sunzenshen sunzenshen closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Animation stuff. Including the syncronizing of animations between client and server based on state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants