Skip to content

Fix incorrect DECLARE_CLASS base class - #2278

Merged
Rainyan merged 1 commit into
NeotokyoRebuild:masterfrom
Rainyan:bug/baseclass-decl
Nov 18, 2026
Merged

Rainyan merged 1 commit into
NeotokyoRebuild:masterfrom
Rainyan:bug/baseclass-decl

Conversation

@Rainyan

@Rainyan Rainyan commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description

Fix the self-referential typo in the macro class decl. This should have no practical consequence whatsoever for current behaviour, but it's currently incorrect. And if the subclass were to call the BaseClass::method(...) pattern for walking up the superclass chain, it would blow up in a stack overflow from infinite recursion.

Pretty sure this pattern happens no where else in our code, outside the (unused) hl2 rpg stuff: grep -EInr "DECLARE_CLASS.*\b(\w+)\,\s+\1\b"

Toolchain

  • Windows MSVC VS2022

Linked Issues

  • fixes #
  • related #

@Rainyan
Rainyan requested a review from a team November 6, 2026 12:05
@AdamTadeusz
AdamTadeusz requested a review from a team November 8, 2026 11:49
@Rainyan Rainyan closed this Nov 8, 2026
@Rainyan Rainyan reopened this Nov 18, 2026
@Rainyan
Rainyan merged commit 6f53bb2 into NeotokyoRebuild:master Nov 18, 2026
18 checks passed
@Rainyan
Rainyan deleted the bug/baseclass-decl branch November 18, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants