Skip to content

Pistol animations stay in slide lock open position during idle and reload states - #2259

Merged
sunzenshen merged 7 commits into
NeotokyoRebuild:masterfrom
sunzenshen:vm-empty-slide-assets
Nov 7, 2026
Merged

sunzenshen merged 7 commits into
NeotokyoRebuild:masterfrom
sunzenshen:vm-empty-slide-assets

Conversation

@sunzenshen

@sunzenshen sunzenshen commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Depends on NeotokyoRebuild/neoAssets#170

The Tachi and Milso viewmodels include empty-magazine animations, but the game did not use them. An empty pistol could show the slide forward after firing, drawing, or reloading.

This change uses the empty idle and draw sequences when the clip is empty, plays the slide-locked firing sequence on the last shot, and uses reloadempty when the model provides it. Empty reloads also trigger the third-person reload gesture. Weapons without these sequences keep their current animations. The Tachi's empty-reload animation requires NeotokyoRebuild/neoAssets#170.

Testing: Checked empty and partial firing, switching, and reloads for both pistols, plus loaded pistols and rifles as controls. The Debug bot checks had no new asserts beyond the known startup assert.

Toolchain

  • Windows MSVC VS2022
  • Linux Mint GCC

Linked Issues

Testing

  1. Set cl_autoreload_when_empty to 0, then fire the magazine dry.
  2. Reload from empty. The slide should stay back until the new magazine is seated, then slide forward.
  3. Reload with rounds still in the magazine. The standard reload animation should play, with normal slide behavior.

@sunzenshen

Copy link
Copy Markdown
Contributor Author

This PR (2259) is the more complete solution, but I am proposing #2248 simultaneously, because I think we need to figure out how to handle the raw precompiled animation files from NeotokyoRebuild/neoAssets#170 . Maybe they shouldn't be in neoAssets? So it might be easier to merge 2248 first before we figure out the answer to animation file management.

@sunzenshen
sunzenshen requested a review from a team October 17, 2026 02:00
@sunzenshen
sunzenshen marked this pull request as ready for review October 17, 2026 02:03
@sunzenshen sunzenshen added the Animations Animation stuff. Including the syncronizing of animations between client and server based on state. label Oct 17, 2026
@sunzenshen

Copy link
Copy Markdown
Contributor Author

Demo of the custom tachi slide-open animation (right most example) compared to a code only solution:

682226330-b7f4b4ea-ef36-4313-8a63-cf044174e7c4.mp4

@sunzenshen

sunzenshen commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Added a blender project for hand posing the animations.

The Tachi and Milso viewmodels have an idle01empty sequence with the
slide held back, which neo never played: an emptied pistol held its
last fire frame for 2.0 s and then idled with the slide forward. The
original NEOTOKYO holds the slide back from the end of the last shot
until the reload. Send ACT_VM_IDLE_EMPTY for ACT_VM_IDLE while the
clip is empty, as the SDK crossbow does, and go to it as the emptying
shot's sequence ends. Models without the sequence are unchanged.
The Tachi and Milso viewmodels ship a drawempty sequence, the normal
draw with the slide held back, but it carries no activity, so an
empty pistol drew with the slide forward and only pulled it back as
the empty idle faded in. Pick drawempty by name in Deploy when the
clip is empty. Models without it, and loaded draws, are unchanged.
The shot that emptied a Tachi or Milso played its normal fire sequence,
whose slide closes within 0.2 s, and the slide went back only when the
empty idle followed 0.4 s later. Both pistols ship a dry fire sequence
that is a shot's kick with the slide held back throughout, ending on
the empty idle's pose, so the last round's shot plays that instead.
A reload always played the reload sequence, whose slide is forward from
its first frame, so the slide of an empty pistol closed as the reload
began. The Milso ships a reload for an empty gun (ACT_VM_RELOAD_EMPTY)
that keeps the slide back until its release near the end, the same
length as the reload; an empty weapon now plays it where the model has
one.
@sunzenshen
sunzenshen force-pushed the vm-empty-slide-assets branch from 3adcb38 to e84fa2e Compare October 26, 2026 04:48
Preserve the empty-slide reload while incorporating upstream reload timing. Confirmed by a successful Debug build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sunzenshen sunzenshen changed the title Pistol slide lock with the Tachi reload asset (pairs with neoAssets) Pistol animations stay in slide lock open position during idle and reload states Oct 29, 2026
AdamTadeusz
AdamTadeusz previously approved these changes Oct 29, 2026
@AdamTadeusz
AdamTadeusz requested a review from a team October 31, 2026 10:49
@sunmachine
sunmachine self-requested a review November 3, 2026 03:33
@sunzenshen
sunzenshen merged commit bfff5b3 into NeotokyoRebuild:master Nov 7, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Animation stuff. Including the syncronizing of animations between client and server based on state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tachi slide shouldn't move when dry firing

3 participants