Skip to content

[WONTFIX?] Hold the jump pose until a drawn player lands - #2241

Closed
sunzenshen wants to merge 2 commits into
NeotokyoRebuild:masterfrom
sunzenshen:anim-jump-end-on-landing
Closed

sunzenshen wants to merge 2 commits into
NeotokyoRebuild:masterfrom
sunzenshen:anim-jump-end-on-landing

Conversation

@sunzenshen

@sunzenshen sunzenshen commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Other players can leave the jump pose before their interpolated model reaches the ground, then show walk legs while still in the air. On clients, this change keeps the pose until a short hull trace beneath the drawn player finds ground. If the trace finds no ground, a 0.5-second fallback ends the pose after the ground flag is set. The server and local player keep the ground-flag check. Movement detection also uses horizontal speed, so vertical motion alone no longer selects walk legs; ladder movement keeps its existing 3D check.

Testing: Compared per-frame animation logs with classic and master. On master, the pose ended 0.19–0.27 seconds before the drawn landing; on this branch it ended on the landing frame. The Debug check reported no new asserts.

Linked Issues

  • None.

The legs and feet decided "moving" on 3D speed, so a player rising
or falling (a jump, a drop off a ledge, a lift) played the walk
animation in the air. Classic NEOTOKYO and the 2006 SDK use
horizontal speed. Ladders keep the 3D test, so climbing keeps the
walk animation it has today.
The jump pose ended when the client saw the ground flag, 0.2 s or
more after take-off. The flag is networked as received, but other
players are drawn at an interpolated position that trails it by a
few tenths of a second, so the pose ended near the top of the jump
and the body came down in the walk pose. On the client, the jump
now lasts until a short hull trace finds ground under the drawn
body, or until the flag has been set for 0.5 s. The server and the
flag test are unchanged.
@sunzenshen sunzenshen added the Animations Animation stuff. Including the syncronizing of animations between client and server based on state. label Oct 15, 2026
@sunzenshen

sunzenshen commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Comparison of the classic/master/fixed versions (Click the gif to animate):

image-1792041581072

@sunzenshen
sunzenshen requested a review from a team October 15, 2026 05:21
@sunzenshen
sunzenshen marked this pull request as ready for review October 15, 2026 05:21
@sunzenshen
sunzenshen removed the request for review from a team October 15, 2026 07:01
@sunzenshen
sunzenshen marked this pull request as draft October 15, 2026 07:02
@sunzenshen

Copy link
Copy Markdown
Contributor Author

#2244 might actually accomplish the same and better than this, so waiting of the result of that review before deciding what to do with this PR.

(This PR edits hl2mp_playeranimstate.*, which #2244 no longer uses and could even remove from the build.)

@sunzenshen sunzenshen changed the title Hold the jump pose until a drawn player lands [WONTFIX?] Hold the jump pose until a drawn player lands Oct 16, 2026
@sunzenshen

Copy link
Copy Markdown
Contributor Author

(Have a backup in case we need this again, but is likely obviated by #2244.)

@sunzenshen sunzenshen closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Animation stuff. Including the syncronizing of animations between client and server based on state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant