Repository navigation
[WONTFIX?] Hold the jump pose until a drawn player lands - #2241
Closed
sunzenshen wants to merge 2 commits into
Closed
sunzenshen wants to merge 2 commits into
sunzenshen wants to merge 2 commits into
Conversation
The legs and feet decided "moving" on 3D speed, so a player rising or falling (a jump, a drop off a ledge, a lift) played the walk animation in the air. Classic NEOTOKYO and the 2006 SDK use horizontal speed. Ladders keep the 3D test, so climbing keeps the walk animation it has today.
The jump pose ended when the client saw the ground flag, 0.2 s or more after take-off. The flag is networked as received, but other players are drawn at an interpolated position that trails it by a few tenths of a second, so the pose ended near the top of the jump and the body came down in the walk pose. On the client, the jump now lasts until a short hull trace finds ground under the drawn body, or until the flag has been set for 0.5 s. The server and the flag test are unchanged.
Contributor
Author
sunzenshen
marked this pull request as ready for review
October 15, 2026 05:21
This was referenced Oct 15, 2026
sunzenshen
marked this pull request as draft
October 15, 2026 07:02
Contributor
Author
Contributor
Author
|
(Have a backup in case we need this again, but is likely obviated by #2244.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Other players can leave the jump pose before their interpolated model reaches the ground, then show walk legs while still in the air. On clients, this change keeps the pose until a short hull trace beneath the drawn player finds ground. If the trace finds no ground, a 0.5-second fallback ends the pose after the ground flag is set. The server and local player keep the ground-flag check. Movement detection also uses horizontal speed, so vertical motion alone no longer selects walk legs; ladder movement keeps its existing 3D check.
Testing: Compared per-frame animation logs with classic and master. On master, the pose ended 0.19–0.27 seconds before the drawn landing; on this branch it ended on the landing frame. The Debug check reported no new asserts.
Linked Issues