Skip to content

[WONTFIX?] Blend the player upper body by speed like classic NEOTOKYO - #2240

Closed
sunzenshen wants to merge 2 commits into
NeotokyoRebuild:masterfrom
sunzenshen:anim-upper-body-blend
Closed

sunzenshen wants to merge 2 commits into
NeotokyoRebuild:masterfrom
sunzenshen:anim-upper-body-blend

Conversation

@sunzenshen

@sunzenshen sunzenshen commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Small movements currently switch the upper body to the full walk animation. This change keeps the idle upper-body layer and blends in the walk, run, or crouch-walk layer according to horizontal speed, following the 2006 SDK animation blend used by classic NEOTOKYO. A short fade prevents the moving layer from snapping off when movement stops in one frame. Leg animation and the standing idle torso are unchanged.

Testing: Compared per-frame logs with classic and master. The new blend followed the SDK's expected weight within 0.02; slow movement no longer played a full-strength walk torso (35 of 52 frames on master, 0 of 182 on this branch). The change adds two animation overlays per player.

Linked Issues

  • None.

neo plays the walk upper body at full weight from the first 0.5 u/s of
movement, so a player who drifts, peeks or eases to a stop bobs the
torso at the 0.73 s walk loop instead of the 2 s idle breathing, with a
0.2 s crossfade at each start and stop.

Classic NEOTOKYO, like the 2006 SDK player anim state it is built on,
always plays the idle upper body and blends the walk, sprint or crouch
walk upper body over it at 2D speed / 100, 250 or 85 u/s. Do the same
with a second pair of aim layers and its own sequence transitioner.
A player who stops in one frame (a wall, or releasing walk) dropped the
walk torso from near full weight to zero at once, a visible snap that
the old 0.2 s crossfade between the torso sequences used to hide.
Classic NT snaps here too; fade the last moving pose out over the same
0.2 s instead. A normal friction stop is slower than the fade, so the
speed blend is unchanged there.
@sunzenshen sunzenshen added the Animations Animation stuff. Including the syncronizing of animations between client and server based on state. label Oct 15, 2026
@sunzenshen

sunzenshen commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Demos (click gifs to animate):

r1-taps-triptych r1-taps

@sunzenshen
sunzenshen requested a review from a team October 15, 2026 05:26
@sunzenshen
sunzenshen marked this pull request as ready for review October 15, 2026 05:26
@sunzenshen
sunzenshen removed the request for review from a team October 15, 2026 07:01
@sunzenshen
sunzenshen marked this pull request as draft October 15, 2026 07:01
@sunzenshen

Copy link
Copy Markdown
Contributor Author

#2244 might actually accomplish the same and better than this, so waiting of the result of that review before deciding what to do with this PR.

(This PR edits multiplayer_animstate.*, which #2244 no longer uses and could even remove from the build.)

@sunzenshen sunzenshen added the wontfix This will not be worked on label Oct 16, 2026
@sunzenshen sunzenshen changed the title Blend the player upper body by speed like classic NEOTOKYO [WONTFIX?] Blend the player upper body by speed like classic NEOTOKYO Oct 16, 2026
@sunzenshen

Copy link
Copy Markdown
Contributor Author

(Have a backup in case we need this again, but is likely obviated by #2244.)

@sunzenshen sunzenshen closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Animation stuff. Including the syncronizing of animations between client and server based on state. wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant