Fix #3763: avisa de conflictos de nombres al extender clases - #2018
Open
AdelantiaDev wants to merge 2 commits into
Open
Fix #3763: avisa de conflictos de nombres al extender clases#2018AdelantiaDev wants to merge 2 commits into
AdelantiaDev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Implementa la tarea #3763: avisa al desarrollador cuando dos extensiones registran un método con el mismo nombre en un modelo o controlador.
Hasta ahora, si dos plugins añadían por extensión un método homónimo sin usar
pipe(),__call()ejecutaba solo el primero y el segundo se ignoraba en silencio. Ahora, cuando__call()detecta más de una extensión para el mismo nombre, registra unwarning(una sola vez por clase+método) indicando el conflicto y sugiriendo usarpipe(). No se modifica el comportamiento de ejecución nipipe().Archivos:
Core/Template/ExtensionsTrait.php: detección y aviso del conflicto.Test/Core/Template/ExtensionsTraitTest.php: pruebas del aviso.¿Cómo has probado los cambios?