Fix clean_module to return False on non-zero exit#4
Open
containergu wants to merge 1 commit into
Open
Conversation
- Check subprocess return code instead of always returning True - Include module name and stderr/stdout in failure messages - Handle TimeoutExpired and FileNotFoundError gracefully - Keep existing successful behavior returning True Diagnostic: build-61f27f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
clean_modulefunction previously ignored the subprocess return code and always returnedTrue. This masked build failures during the clean step, making it impossible to detect when a module cleanup failed.Changes
subprocess.runresult and checkreturncodeFalsewith the module name and exit code on failureTimeoutExpiredandFileNotFoundErrorseparately with specific messagesTesting
clean_modulenow properly surfaces non-zero exit codesDiagnostics
Build diagnostic files committed: build-61f27f9
Claim: Bounty payment for clean_module fix.
Wallet: 0xfBF558DC0B795E8b6002220FC29c161ab71031CF (Base network)