Repository navigation
noImplicitAny, batch 6: the mpv helper typed without a forced reinstall (880 to 766) - #547
Merged
Merged
Conversation
BlobManager, fetch-amo-signed, AbstractAudioModule, check-patched-updates, VpnPrompt, ast-compare, VMPlayer, VolumeControls (glm's answers, checked). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The helper's 76 untyped places get types, comments only (glm's answers, two lines finished by hand: queryDecoder takes no wait as 0). Its version goes to 20 while RequiredHostVersion stays 19: a change that alters no behaviour no longer has every installed helper reported outdated. The version test now checks RequiredHostVersion <= HostVersion (red with 21); docs and CLAUDE.md say when Required moves. Record: 766. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
HostVersion. Two lines were finished by hand:queryDecodertreats a missing wait as 0, and a pid checked withNumber.isIntegeris a number.No reinstall for it.
HostVersiongoes to 20 andRequiredHostVersionstays 19. The add-on accepts any helper at or above the required version, so installed helpers (19) keep working, and nobody is told to reinstall for a change that alters no behaviour.tests/unit/mpvHostVersion.test.mjscheckedRequiredHostVersion == HostVersion. It now checksRequiredHostVersion <= HostVersion, red with 21.docs/notes/mpv.md,docs/notes/type-checking.mdandCLAUDE.mdsay when Required moves: only when the extension needs what the new helper does.The helper is released the same way as before, under a new version number. CI's mpv specs run the real helper on Windows.
Checked locally: lint,
tsc --noEmit, the ratchet (766), 2886 unit tests (83 helper tests).🤖 Generated with Claude Code