Skip to content

fix(napi): don't touch async work after its complete callback - #13

Closed
triniwiz wants to merge 1 commit into
mainfrom
fix/napi-async-work-after-free
Closed

triniwiz wants to merge 1 commit into
mainfrom
fix/napi-async-work-after-free

Conversation

@triniwiz

Copy link
Copy Markdown
Member

A complete callback may free the work with napi_delete_async_work, as Node allows and napi-rs does, so read env, complete and data before calling it.

A complete callback may free the work with napi_delete_async_work, as Node
allows and napi-rs does, so read env, complete and data before calling it.
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3e616cf0-a17b-4314-a2c5-9bbf128ad0de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@triniwiz triniwiz closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant