Skip to content

Add webhook self-certification and preflight submission checks#350

Merged
simonhamp merged 2 commits intomainfrom
self-certify-webhook
Apr 11, 2026
Merged

Add webhook self-certification and preflight submission checks#350
simonhamp merged 2 commits intomainfrom
self-certify-webhook

Conversation

@simonhamp
Copy link
Copy Markdown
Member

@simonhamp simonhamp commented Apr 11, 2026

Summary

  • Developers can self-certify webhook installation when automatic registration fails, with manual setup instructions always visible
  • Adds "Retry automatic setup" button alongside self-certification
  • Preflight checks (license file, release version, webhook) now gate plugin submission — plugins stay in draft until all required checks pass
  • Verifies webhook existence via GitHub API during preflight checks, correcting stale webhook_installed flags
  • Adds description validation to submission flow
  • Enhances plugin summary card with author name, version, license, min iOS/Android versions, and support channel with appropriate links
  • Replaces session flash banners with Flux toasts and adds <flux:toast /> to the dashboard layout
  • Scrolls to first validation error on form submission failures
  • ReviewPluginRepository now always populates review_checks even when GitHub API calls fail, ensuring the checks panel always renders

Test plan

  • 31 tests passing across PluginStatusTransitionsTest, PluginWebhookCertificationTest, and CustomerPluginReviewChecksTest
  • Verify webhook self-certification flow works end-to-end
  • Verify preflight checks block submission when license/release/webhook missing
  • Verify Flux toasts appear correctly for success and error states
  • Verify scroll-to-error works on form validation failures
  • Verify plugin summary card shows all details with correct links

🤖 Generated with Claude Code

simonhamp and others added 2 commits April 11, 2026 14:07
…enhancements

- Let developers self-certify webhook installation when auto-registration fails
- Add retry automatic webhook setup button
- Verify webhook existence via GitHub API during preflight checks
- Gate plugin submission on preflight checks (license, release, webhook)
- Add description validation to submission flow
- Enhance plugin summary card with author, version, license, min iOS/Android
- Replace session flash messages with Flux toasts
- Add scroll-to-first-error on validation failures
- Always show webhook setup instructions when check fails
- Always populate review_checks even when GitHub API calls fail
- Add flux:toast to dashboard layout

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@simonhamp simonhamp marked this pull request as ready for review April 11, 2026 14:41
@simonhamp simonhamp merged commit 0dc6707 into main Apr 11, 2026
2 checks passed
@simonhamp simonhamp deleted the self-certify-webhook branch April 11, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant