You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When attempting a GeniePlus reharvest after upgrading to the latest RecordManager, I discovered that OAuth renewals were not working correctly because Laminas HTTP error handling differs from Guzzle HTTP error handling. This PR fixes the problem -- it may be worth reviewing whether any other drivers have similar problems.
TODO
Run local test to confirm refactored code still works before merging
The reason will be displayed to describe this comment to others. Learn more.
I think it would be cleaner to set http_errors to false in $this->httOptions. I did a similar change to SierraApi quite recently, but didn't realize at the time that GeniePlus was similarly affected.
Thanks, @EreMaijala, I agree! My first pass on this was an attempt to use the http_errors setting, but I think I was putting it in the wrong place and it wasn't working. I have revised the code based on your SierraRest example, and I think this should work. I'm running a test now but will have to wait at least 20 minutes to be sure it works. I'll request a re-review now, but please do not merge this until I have confirmed that it actually works on my end!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting a GeniePlus reharvest after upgrading to the latest RecordManager, I discovered that OAuth renewals were not working correctly because Laminas HTTP error handling differs from Guzzle HTTP error handling. This PR fixes the problem -- it may be worth reviewing whether any other drivers have similar problems.
TODO