Fix solr compare records output - #203
Open
kouralex wants to merge 2 commits into
Open
Conversation
EreMaijala
requested changes
Aug 3, 2026
EreMaijala
left a comment
EreMaijala
left a comment
Contributor
There was a problem hiding this comment.
Adding callnumber-search makes sense, but unless I missed something the rest of the fields are only present in the downstream Finna-specfic version and should be listed there, if anywhere. Note that you can always add any desired fields to the ignore_in_comparison setting in [Solr] section of recordmanager.ini.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./console solr:compare-recordsafter indexing a direct file import and importing them again via the same file results in displaying excessive changes. It seems like some fields are created internally by Solr whilst indexing and those do not exist from RecordManager's view for some reason.