fix: give stdout and stderr their own output byte budget - #1158
Open
kishore280 wants to merge 1 commit into
Open
fix: give stdout and stderr their own output byte budget#1158kishore280 wants to merge 1 commit into
kishore280 wants to merge 1 commit into
Conversation
kishore280
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
September 2, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
stdout and stderr shared one byte counter and one truncation flag. A noisy stderr could exhaust the shared budget first, silently dropping stdout data after that point with no marker at all - the caller had no way to know anything was cut.
Split into two independent pairs, one per stream. Each stream's truncation now depends only on its own volume, and gets its own marker when it happens.
Ran: test:ava on bash-executor.spec.ts (two new tests, one per direction), test:types, test:lint, test:format, test:changesets.