fix(schedule): render */N minute as "every N minutes" - #1154
Open
MsfPablo wants to merge 1 commit into
Open
Conversation
formatCronHuman matched */N minute expressions against the hourly branch and rendered them verbatim as "every hour at minute */5", leaking raw cron syntax into the human label. Add an explicit every-N-minutes branch so "*/5 * * * *" renders as "every 5 minutes". Closes Nano-Collective#1132
MsfPablo
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
September 2, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatCronHumanleaked raw cron syntax for*/Nminute expressions.*/5 * * * *matched the hourly branch (any non-*minute with every other field wildcard) and rendered verbatim asevery hour at minute */5.Added an explicit every-N-minutes branch so
*/5 * * * *renders asevery 5 minutes, and*/15 * * * *asevery 15 minutes.Closes #1132.
Test plan
formatCronHuman formats every-N-minutes without leaking cron syntax(fails without the fix, passes with it)tsc --noEmitcleanbiome checkcleanpatch)