fix: quote parameters correctly for cmd.exe custom tools - #1124
Open
awhite0030 wants to merge 1 commit into
Open
fix: quote parameters correctly for cmd.exe custom tools#1124awhite0030 wants to merge 1 commit into
awhite0030 wants to merge 1 commit into
Conversation
This addresses an issue where parameters substituted into custom tool templates were quoted using POSIX single-quotes globally. Under `cmd.exe` on Windows, these quotes are treated literally rather than as escape mechanisms, which broke paths like `type 'notes.txt'` and left shell metacharacters unprotected. Now, `template.ts` takes an optional `shell` hint and branches quoting behavior: POSIX uses `shellQuote` while `cmd.exe` uses `cmdQuote`, which correctly escapes `%`, `&`, `|`, `<`, `>`, and `^` and uses double quotes. Fixes Nano-Collective#1084
awhite0030
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
September 1, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR does
Type of Change
Changeset
pnpm changeset) describing this change for the changelogDocs-only or internal chores need no changeset (or run
pnpm changeset --emptyto note that intentionally).Testing
Automated Tests
.spec.ts/tsxfilespnpm test:allcompletes successfully)Manual Testing
Checklist
Root cause: The custom tool template engine universally applied POSIX single-quote escaping for all arguments (
renderValue->shellQuote). On Windowscmd.exe, this resulted in strings wrapped in literal'marks, breaking file paths and failing to prevent shell injection vectors from characters like&and%VAR%.Fix: Extracted
isWindowsCmdfromhandler.tsand introduced acmdQuotefunction intemplate.tsthat escapes metacharacters%,&,|,<,>, and^by prefixing them with^and wrapping the argument in double quotes. The template renderer now takes the shell as an optional parameter and usescmdQuoteif it detects a Windowscmdshell.Validation:
(Note: Only custom-tools tests were run via
avadue to container environment timeouts)Fixes #1084
Fixes #1084