feat(typescript): migrate JSX components to TSX with typed interfaces#517
Merged
Nanle-code merged 1 commit intoJun 30, 2026
Merged
Conversation
… (issue Nanle-code#403) Convert 8 JSX components to TSX with full TypeScript interfaces and strict mode: - src/components/accessibility/AccessibilityProvider.jsx → .tsx: typed children prop - src/components/accessibility/FocusManager.jsx → .tsx: FocusManagerProps interface, typed refs and event handlers - src/components/accessibility/ScreenReaderAnnouncer.jsx → .tsx: typed subscription callback - src/components/addressLabels/AddressLabelBadge.jsx → .tsx: AddressLabelBadgeProps interface, typed event handlers - src/components/dashboard/CrossNetworkPanel.jsx → .tsx: ProbeResult/ComparisonResult/CrossNetworkPanelProps interfaces, typed Zustand selectors - src/components/dashboard/RelationshipPanel.jsx → .tsx: full domain interfaces (Relationship, RankedNode, Cluster, RelationshipReport, LabelMap) for all sub-components - src/components/dashboard/TimeAnalysis.jsx → .tsx: Operation/DailyVolume/TimeAnalysisResult interfaces, typed Recharts formatters - src/components/layout/NetworkIndicator.jsx → .tsx: NetworkIndicatorProps interface tsconfig.json: enable strict, noImplicitAny, strictNullChecks (previously all false) Closes Nanle-code#403 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@brite-side0 is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@brite-side0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #403
Converts 8 JSX components to TSX with full TypeScript interfaces, and enables strict mode in
tsconfig.json.Converted components
accessibility/AccessibilityProviderAccessibilityProviderPropsaccessibility/FocusManagerFocusManagerProps, typeduseRef<HTMLDivElement>, typedKeyboardEventhandleraccessibility/ScreenReaderAnnounceraddressLabels/AddressLabelBadgeAddressLabelBadgeProps,Categoryinterfacedashboard/CrossNetworkPanelProbeResult,ComparisonResult,CrossNetworkPanelPropsdashboard/RelationshipPanelRelationship,RankedNode,Cluster,ReportSummary,RelationshipReport,LabelMapfor all sub-componentsdashboard/TimeAnalysisOperation,DailyVolume,TimeAnalysisResult, typed Recharts formatterslayout/NetworkIndicatorNetworkIndicatorPropsConfig changes
tsconfig.json:strict: true,noImplicitAny: true,strictNullChecks: true(previously allfalse)Test plan
🤖 Generated with Claude Code