Repository navigation
test(e2e): verify the panel in a real browser - #13
Merged
Merged
Conversation
25 Playwright tests in a self-contained e2e/ folder cover the landing and reduced motion, the buyer and organizer views, the language selector (default, switch, persistence, no missing keys on any route), the buyer link and its QR code (decoded by jsQR from a capture of the screen), the offline shell and the 360 px layout. They run in their own CI job so a browser flake never hides the .NET result, with a pinned lockfile, npm audit and Dependabot for e2e/. Nothing in e2e/ ships and the panel gains no dependency.
ADR-0011 (Proposed) records the choice of Playwright outside the panel. REQ-090 to REQ-096 and REQ-101 to REQ-105 move into the requirements with their tests; the traceability gap now lists only what is still not automated (installing on a physical phone). Runbook, README, changelog and the spec task lists are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the gap the traceability matrix admitted: the panel's visual behaviour is now verified by tests, in a real browser, against the real application (task T-056, ADR-0011 Proposed).
e2e/: 25 Playwright tests, self-contained (ownpackage.jsonand lockfile). Nothing in it ships; the panel gains no dependency or build step.jsQRfrom a screen capture, independent of the encoder), offline shell and API never faked, 360 px layout and 44 px targets.Browser tests, so a browser flake never hides the .NET result.npm audit, a pinned lockfile and Dependabot fore2e/.Verification
npx playwright test25/25 locally (Edge channel); a mutation check (breaking the QR format bits) makes the QR test fail, then reverted.actionlintclean,npm auditclean,gitleaksclean.zizmorreports the repository's existing unpinned-action findings; the new job follows the same convention as the existing ones.Not verified
The new CI job has not run on a GitHub runner yet (Linux, Playwright's bundled Chromium); this PR is its first run. Based on
feat/mobile-pwa(PR #12) because the tests cover its features; GitHub retargets it tomainwhen #12 merges.