Repository navigation
Initialize stop-when's once-flag before the callbacks that use it - #2327
Merged
Merged
Conversation
__fused_token::callback_type declared __called_ after __cb1_ and __cb2_. If the first token is already stopped, __cb1_'s constructor invokes the callback, which reads and sets __called_ before its lifetime begins; the member initializer then stores false. Depending on the indeterminate value, the stop is skipped (and lost if the second token never stops) or the function runs a second time when the second token stops. The draft requires it to run at most once ([exec.stop.when]). Regression from 6720837 (NVIDIA#2234), which moved __called_ to the end. Signed-off-by: Zhavoronkov Aleksei <a.zhavoronkov@adguard.com>
ericniebler
approved these changes
Oct 12, 2026
Collaborator
|
/ok to test 5132851 |
Contributor
Author
|
@ericniebler Could you please re-run CI so we can merge the PR? |
Collaborator
|
/ok to test df2c471 |
Contributor
Author
|
Not a test failure: On 5132851 this check passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2326