Skip to content

Make visible devices configurable - #1935

Open
sstrk wants to merge 1 commit into
NVIDIA:mainfrom
sstrk:feature/make-visible-devices-configurable
Open

Make visible devices configurable#1935
sstrk wants to merge 1 commit into
NVIDIA:mainfrom
sstrk:feature/make-visible-devices-configurable

Conversation

@sstrk

@sstrk sstrk commented Jul 20, 2026

Copy link
Copy Markdown

As adjusting this env var is necessary for the current suggested workaround for issues 1 and 2.
This saves overhead for operators who previously had to adjust the env var via a kustomization or helm post-renderer.

@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

As adjusting this env var is necessary for the current suggested
workaround for issues [1] and [2].
This saves overhead for operators who previously had to adjust the env
var via a kustomization or helm post-renderer.

  [1]: NVIDIA#1683
  [2]: NVIDIA/nvidia-container-toolkit#1740

Signed-off-by: Steve Starke <steve.starke@cloudandheat.com>
@sstrk
sstrk force-pushed the feature/make-visible-devices-configurable branch from 64094cb to 459a737 Compare July 20, 2026 13:09
@myeolenv

myeolenv commented Aug 1, 2026

Copy link
Copy Markdown

Thanks for the contribution. We will review this PR.

@cdesiniotis

Copy link
Copy Markdown
Contributor

@sstrk my preference would be to not add this option to the top-level helm values, as those are typically reserved for common config shared by both k8s-device-plugin and GFD (which can both be deployed by the chart). I would be more open to introducing a common field for passing arbitrary envvars to the device-plugin main container. For example:

devicePlugin:
  containers:
    init: {}
    main:
      env:
        - name: NVIDIA_VISIBLE_DEVICES
          value: "all"
    sidecar: {}

@tariq1890 @rahulait let me know if you have any strong opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants