Skip to content

Use runtime host firmware config in upgrade flows (#3061)#3118

Open
rahmonov wants to merge 1 commit into
NVIDIA:release/v2.0from
rahmonov:consume-db-firmware
Open

Use runtime host firmware config in upgrade flows (#3061)#3118
rahmonov wants to merge 1 commit into
NVIDIA:release/v2.0from
rahmonov:consume-db-firmware

Conversation

@rahmonov

@rahmonov rahmonov commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Cherry-picking #3061.

Apply DB-backed host firmware config overrides on top of static and metadata.toml firmware catalogs across firmware listing, desired firmware snapshotting, site explorer, host reprovisioning, machine update handling, and preingestion.

Runtime config now participates in version comparison and upgrade selection, while metadata remains the base catalog and DB values take precedence when they overlap.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactori

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Apply DB-backed host firmware config overrides on top of static and
metadata.toml firmware catalogs across firmware listing, desired
firmware snapshotting, site explorer, host reprovisioning, machine
update handling, and preingestion.

Runtime config now participates in version comparison and upgrade
selection, while metadata remains the base catalog and DB values take
precedence when they overlap.

<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [x] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

<!-- How was this tested? Check all that apply -->
- [x] Unit tests added/updated
- [x] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)
@copy-pr-bot

copy-pr-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eeaef987-bcd8-4221-9ab6-257a31cd3c67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rahmonov rahmonov marked this pull request as ready for review July 3, 2026 09:03
@rahmonov rahmonov requested a review from a team July 3, 2026 09:03
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-07-03 09:07:24 UTC | Commit: cb2bb6f

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 270 5 25 89 7 144
machine-validation-runner 771 25 207 278 40 221
machine_validation 771 25 207 278 40 221
machine_validation-aarch64 771 25 207 278 40 221
nvmetal-carbide 771 25 207 278 40 221
TOTAL 3360 105 853 1207 167 1028

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant