fix(vgpu-device-manager): wait for host-installed vGPU Manager readiness#2599
Open
lexfrei wants to merge 1 commit into
Open
fix(vgpu-device-manager): wait for host-installed vGPU Manager readiness#2599lexfrei wants to merge 1 commit into
lexfrei wants to merge 1 commit into
Conversation
The vgpu-manager-validation init container waited only for the vgpu-manager-ready status file, which the validator writes when the vGPU Manager is deployed as a container. When the vGPU Manager driver is pre-installed on the host (driver.enabled=false), the validator writes host-vgpu-manager-ready instead, so the init container blocked indefinitely on "waiting for NVIDIA vGPU Manager to be setup" and the vGPU Device Manager never started. Wait for either status file so the operand starts in both the container-managed and host-installed driver modes, resolving the existing TODO in the daemonset asset. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
lexfrei
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
vgpu-manager-validationinit container of thenvidia-vgpu-device-managerDaemonSet waited only for thevgpu-manager-readystatus file, which the validator writes when the vGPU Manager is deployed as a container. When the vGPU Manager driver is pre-installed on the host (driver.enabled=false), the validator instead writeshost-vgpu-manager-ready(and deletes both files at the start of each run), so the init container blocked indefinitely on "waiting for NVIDIA vGPU Manager to be setup" and the vGPU Device Manager never started.host-vgpu-manager-readyis written by the validator but read nowhere else in the tree, so the host-installed-driver path never had a working readiness gate. There was already aTODOnext to the gate acknowledging this.This makes the init container wait for either status file, so the operand starts in both the container-managed and host-installed driver modes, and resolves that
TODO.Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Added
TestVGPUDeviceManagerReadinessGate(controllers package) which decodes the daemonset asset and asserts the init container's readiness gate waits for bothvgpu-manager-readyandhost-vgpu-manager-ready, combined with||(OR) so it passes when either file is present. Verified red/green: the test fails on the previous single-file gate and on an accidental&&, and passes with the fix.go test ./controllers/,go vet ./controllers/, andgolangci-lint runon the changed package all pass. This changes only a static asset and a unit test, soapi/,config/,bundle/,deployments/, and the module files are untouched.