-
Notifications
You must be signed in to change notification settings - Fork 9
chore(docs): add component preview to card list #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ import styles from './notification.css?inline'; | |
|
|
||
| /** | ||
| * @element nve-notification | ||
| * @description Displays real time updates without interrupting the user's workflow to communicate an important message or status. [MDN Popover API](https://developer.mozilla.org/en-US/docs/Web/API/Popover_API) | ||
| * @description Displays real time updates without interrupting the user's workflow to communicate an important message or status. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Clarify and hyphenate the notification description. Use As per coding guidelines, TypeScript JSDoc comments are linted by Vale and should follow the repository's technical writing style. Proposed wording- * `@description` Displays real time updates without interrupting the user's workflow to communicate an important message or status.
+ * `@description` Displays important messages or status updates without interrupting the user's workflow.🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| * @documentation https://nvidia.github.io/elements/docs/elements/notification/ | ||
| * @since 0.6.0 | ||
| * @entrypoint \@nvidia-elements/core/notification | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ import styles from './tooltip.css?inline'; | |||||
|
|
||||||
| /** | ||||||
| * @element nve-tooltip | ||||||
| * @description A contextual popup that displays a plaintext description. Tooltips are [triggered](https://w3c.github.io/aria/#tooltip) by hovering, focusing, or tapping an element and cannot have interactive elements within them. [MDN Popover API](https://developer.mozilla.org/en-US/docs/Web/API/Popover_API) | ||||||
| * @description A contextual popup that displays a plaintext description. Trigger tooltips by hovering, focusing, or tapping an element and cannot have interactive elements within them. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Fix the tooltip description grammar. The sentence joins an imperative with a separate subject. State the tooltip behavior directly. As per coding guidelines, TypeScript JSDoc comments are linted by Vale and should follow the repository's technical writing style. Proposed wording- * `@description` A contextual popup that displays a plaintext description. Trigger tooltips by hovering, focusing, or tapping an element and cannot have interactive elements within them.
+ * `@description` A contextual popup that displays a plain-text description. Tooltips are triggered by hovering over, focusing on, or tapping an element and cannot contain interactive elements.📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsSource: Coding guidelines |
||||||
| * @documentation https://nvidia.github.io/elements/docs/elements/tooltip/ | ||||||
| * @since 0.6.0 | ||||||
| * @entrypoint \@nvidia-elements/core/tooltip | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the drawer description grammar.
Drawer areis incorrect. Use a singular subject and a direct description.As per coding guidelines, TypeScript JSDoc comments are linted by Vale and should follow the repository's technical writing style.
Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines