Topic tool cleanup - #198
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR adds an ESLint rule restricting ChangesFull-container placement and page layouts
MCP server catalog configuration
Package metadata and site markup
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant ESLint
participant noRestrictedContainerFull
participant HTMLAST
Developer->>ESLint: lint HTML template
ESLint->>noRestrictedContainerFull: run rule
noRestrictedContainerFull->>HTMLAST: inspect full-container ancestry
HTMLAST-->>noRestrictedContainerFull: return element context
noRestrictedContainerFull-->>ESLint: report error or grid suggestion
ESLint-->>Developer: display lint result
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
scope(core)
scope(internals)
scope(lint)
scope(docs)
scope(styles)
labels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/lint/src/eslint/rules/no-restricted-container-full.ts`:
- Around line 36-47: Update the no-restricted-container-full rule description to
state that container="full" is permitted for template-root elements and direct
children of nve-page. Update the metadata assertion in
projects/lint/src/eslint/rules/no-restricted-container-full.test.ts (lines
42-61), the rule documentation in projects/lint/README.md (line 89), and the
site documentation in projects/site/src/docs/lint/index.md (lines 211-216) to
describe both permitted placements.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 8b59082c-25b3-49a8-b85b-6bf1f6090974
📒 Files selected for processing (22)
projects/core/eslint.config.jsprojects/core/src/alert/alert.examples.tsprojects/core/src/card/card.examples.tsprojects/core/src/grid/grid.examples.tsprojects/core/src/grid/grid.test.visual.tsprojects/core/src/page/page.cssprojects/core/src/page/page.tsprojects/core/src/toggletip/toggletip.examples.tsprojects/core/src/toolbar/toolbar.examples.tsprojects/internals/patterns/src/browse.examples.tsprojects/internals/patterns/src/editor.examples.tsprojects/internals/patterns/src/templates.examples.tsprojects/internals/tools/src/skills/migration.mdprojects/lint/README.mdprojects/lint/src/eslint/configs/html.tsprojects/lint/src/eslint/rules/no-nested-container-types.test.tsprojects/lint/src/eslint/rules/no-nested-container-types.tsprojects/lint/src/eslint/rules/no-restricted-container-full.test.tsprojects/lint/src/eslint/rules/no-restricted-container-full.tsprojects/site/src/docs/elements/data-grid/container.mdprojects/site/src/docs/lint/index.mdprojects/styles/src/layout.css
johnyanarella
approved these changes
Jul 30, 2026
coryrylan
force-pushed
the
topic-tool-cleanup
branch
from
July 30, 2026 19:29
cc511bc to
61da880
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/internals/patterns/src/templates.examples.ts`:
- Around line 835-839: Set --gap: 0 on the nve-page containing the toolbar and
nve-monaco-input in this editor example, matching the FileBrowser configuration,
so the unnamed-slot siblings remain contiguous after removing the main wrapper.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: f001af3c-a29e-4481-93b7-3246176da6dd
📒 Files selected for processing (22)
projects/core/eslint.config.jsprojects/core/src/alert/alert.examples.tsprojects/core/src/card/card.examples.tsprojects/core/src/grid/grid.examples.tsprojects/core/src/grid/grid.test.visual.tsprojects/core/src/page/page.cssprojects/core/src/page/page.tsprojects/core/src/toggletip/toggletip.examples.tsprojects/core/src/toolbar/toolbar.examples.tsprojects/internals/patterns/src/browse.examples.tsprojects/internals/patterns/src/editor.examples.tsprojects/internals/patterns/src/templates.examples.tsprojects/internals/tools/src/skills/migration.mdprojects/lint/README.mdprojects/lint/src/eslint/configs/html.tsprojects/lint/src/eslint/rules/no-nested-container-types.test.tsprojects/lint/src/eslint/rules/no-nested-container-types.tsprojects/lint/src/eslint/rules/no-restricted-container-full.test.tsprojects/lint/src/eslint/rules/no-restricted-container-full.tsprojects/site/src/docs/elements/data-grid/container.mdprojects/site/src/docs/lint/index.mdprojects/styles/src/layout.css
github-actions
Bot
added
scope(ci)
scope(cli)
dependencies
coryrylan
force-pushed
the
topic-tool-cleanup
branch
from
July 30, 2026 19:53
1e6bb5e to
c873349
Compare
coryrylan
force-pushed
the
topic-tool-cleanup
branch
from
July 30, 2026 20:58
c873349 to
e75395f
Compare
Signed-off-by: Cory Rylan <crylan@nvidia.com>
- Introduced a new ESLint rule to restrict the use of container="full" to direct children of nve-page elements. - Updated relevant documentation and examples to reflect this change. - Adjusted existing components and tests to comply with the new linting rule. Signed-off-by: Cory Rylan <crylan@nvidia.com>
- set the width to 100% for elements with the row layout and space-between alignment. - This enhancement improves agent assumptions and layout consistency across components. Signed-off-by: Cory Rylan <crylan@nvidia.com>
Signed-off-by: Cory Rylan <crylan@nvidia.com>
coryrylan
force-pushed
the
topic-tool-cleanup
branch
from
July 30, 2026 21:09
e75395f to
b6a2577
Compare
Collaborator
Author
|
🎉 This issue has been resolved in version 2.1.2 🎉 |
Collaborator
Author
|
🎉 This issue has been resolved in version 2.3.0 🎉 |
Collaborator
Author
|
🎉 This issue has been resolved in version 2.1.9 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
container="full"to direct children of the page, including grid-specific guidance to prefercontainer="flat".nve-pageand adjusted related container modes.--gapsupport for page spacing.