Use cuda::stream_ref for compute APIs - #23649
Merged
Merged
Conversation
vyasr
added
3 - Ready for Review
ChatGPT Codex Connector
bdice
approved these changes
Aug 13, 2026
This reverts commit 542ee95.
bdice
reviewed
Aug 13, 2026
| @@ -2431,7 +2432,7 @@ TEST_F(JoinTest, HashJoinInnerMatchContext) | |||
|
|
|||
| auto const host_match_counts = | |||
| cudf::detail::make_host_vector_async(*match_context._match_counts, stream); | |||
| stream.synchronize(); | |||
| stream.wait(); | |||
Contributor
Contributor
Author
|
Oh boy, didn't realize that. Yes it is. Since CI is basically passing on this PR and hasn't run at all on Bradley's, I'll merge this PR then expand the scope of his to also cover the changes in this PR. |
Contributor
Author
|
/merge |
cursor Bot
pushed a commit
that referenced
this pull request
Aug 14, 2026
Rebase onto main and switch the additional includes introduced by the compute-API stream_ref migration. Co-authored-by: Bradley Dice <bdice@bradleydice.com>
3 tasks
cursor Bot
pushed a commit
that referenced
this pull request
Aug 14, 2026
This file already included <cuda/stream>; the stream_ref rename from #23649 left a second identical include that clang-format rejects. Co-authored-by: Bradley Dice <bdice@bradleydice.com>
rapids-bot Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
CCCL deprecated the `<cuda/stream_ref>` header; `cuda::stream_ref` is now provided by `<cuda/stream>`. This PR switches every `#include <cuda/stream_ref>` to `#include <cuda/stream>` so libcudf builds against newer CCCL. Rebased onto main after #23649 (`Use cuda::stream_ref for compute APIs`) so the additional includes from that migration are covered as well. Also drops a duplicate `<cuda/stream>` include in `top_k.cu` that the rename introduced. The `cuda::stream_ref` type is unchanged. This matches the same change in RMM (rapidsai/rmm#2513) and was observed in rapids-cmake CI: https://github.com/rapidsai/rapids-cmake/actions/runs/31745925779/job/94600794610?pr=1073 Authors: - Bradley Dice (https://github.com/bdice) - Cursor Agent (https://github.com/cursoragent) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #23664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This third batch migrates compute libcudf joins, groupby, reductions, rolling, sorting, transform, unary, and binary operation APIs and tests from
rmm::cuda_stream_viewtocuda::stream_ref. It also includes small follow-up documentation fixes from the previous stream-ref batch.Contributes to #23636
Checklist