Repository navigation
Conversation
Fetch cuda_sanitizer_api from the same pinned redistrib manifest as the rest of the mini CTK, rather than from whatever release ci/tools/guess_latest.sh scrapes from the redist directory listing. Remove guess_latest.sh, which has no other users.
verify-metadata used to warn and pass when a public-server CUDA version had no pinned manifest hash, so the 13.4.2 -> 13.5.0 bump ran unpinned. Fail closed instead, with an explicit fetch_ctk allow-unpinned input (and --allow-unpinned flag) as the opt-out; it never overrides a mismatch against an existing pin. Manifests from an alternate redist server stay warn-only. Pin 13.5.0 and add a test that every CUDA version in ci/versions.yml and every LOCAL_CTK row of ci/test-matrix.yml is pinned.
No caller sets it, and pinning a new CUDA version is a one-line addition to KNOWN_REDISTRIB_SHA256 that the error message points to. Remove the fetch_ctk input and the --allow-unpinned flag; fetch_ctk/action.yml is back to its main-branch form.
Note in ci/versions.yml that each CUDA version there and in LOCAL_CTK matrix rows needs a pin in KNOWN_REDISTRIB_SHA256, and make the coverage test's failure message say where to add the pin and how to compute it.
juenglin
added
CI/CD
Contributor
Contributor
Author
|
/ok to test 26ea52d |
Contributor
|
NVIDIA#2437 made fetch_ctk empty cuda-path before every install. The sanitizer step runs fetch_ctk a second time for cuda_sanitizer_api alone, so it unintentionally deleted the mini CTK installed just before it, and the instrumented test runs failed before any test ran. NVIDIA#2437 then disabled the only matrix rows that run the sanitizer. Add an install-mode input. "add" installs on top of the existing mini CTK at the same cuda-path and keeps the environment the first call exported; the sanitizer step uses it.
juenglin
force-pushed
the
juenglin/tmp-sanitizer-probe
branch
from
November 6, 2026 17:24
26ea52d to
5a7cabf
Compare
3 tasks done
Contributor
Author
|
/ok to test 5a7cabf |
Contributor
Author
|
/ok to test 54c5049 |
juenglin
added a commit
to juenglin/cuda-python
that referenced
this pull request
Nov 6, 2026
With the matrix CTK's own sanitizer, the 12.9.1 and 13.0.2 rows segfaulted partway through the cuda.core tests. With the 13.5.0 sanitizer, both ran the full suite (NVIDIA#3400). This keeps the intent of NVIDIA#594 (newer sanitizer fixes for older toolkits) without the run-time scrape: the version comes from cuda.build.version in ci/versions.yml, which is already pinned.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not merge. Temporary probe for #3397 (based on its head). No row in
ci/test-matrix.ymlcurrently satisfies the compute-sanitizer gate inci/tools/env-vars(Linux, Python 3.12,LOCAL_CTK: '1'), so the sanitizer has not run in CI since the 3.12 / 12.9.1 rows were disabled in #2437.This PR flips the amd64 Python 3.12 rows for 12.9.1, 13.0.2, and 13.5.0 to local-CTK so that the bindings and core test suites run under
compute-sanitizerinstalled from the CTK under test. It will be closed once CI results are in.Checklist