[no-ci] fix(driver): correct cuLogs* introduced version to 12.9 in cuda_bindings_12 (backport #2978) by lijinf2 · Pull Request #3395 · NVIDIA/cuda-python

lijinf2 · 2026-11-05T20:35:18Z

Backport of #2978 to cuda_bindings_12/ on main, matching the 12.9.x backport in #3377.
[no-ci] because there is no CUDA 12 CI on main yet.

🤖 Generated with Claude Code

…da_bindings_12 Apply the changes from NVIDIA#2978 to cuda_bindings_12/ on main: pin the cuGetProcAddress_v2 version for cuLogs* to 12090 (was 12080) and add a regression test. This fixes the cuLogs* FunctionNotFoundError. Matches the 12.9.x backport in NVIDIA#3377. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

copy-pr-bot · 2026-11-05T20:35:22Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

coderabbitai · 2026-11-05T20:40:02Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: NVIDIA/cuda-python
Branch: main
File: .coderabbit.yaml
Commit: 0161596
Layers: Repository YAML
Review profile: CHILL
Plan: Enterprise
Run ID: 64bf9c0f-bb9f-4019-99c6-dcfcd2090e57

Commits

Reviewing files that changed from the base of the PR and between 252f5c2 and 6ad46aa.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

Summary

Summary by CodeRabbit

New Features
- Added support for CUDA 12.9 driver logging APIs, including registering and removing callbacks, retrieving current logs, and writing logs to files or memory buffers.
Compatibility
- The logging APIs now require CUDA 12.9 or later. Earlier CUDA versions can no longer resolve these APIs through the bindings.

The Linux and Windows CUDA 12 bindings now resolve the five cuLogs* APIs at version 12090. A test checks callback registration, log retrieval, and log dumps on CUDA 12.9 or later.

Changes: CUDA 12.9 cuLogs APIs

Layer / File(s)	Summary
cuLogs symbol resolution `cuda_bindings_12/cuda/bindings/_internal/driver_linux.pyx`, `cuda_bindings_12/cuda/bindings/_internal/driver_windows.pyx`	Both platform bindings update the version used to resolve the five `cuLogs*` symbols from 12080 to 12090.
cuLogs API test coverage `cuda_bindings_12/tests/test_cuda.py`	A test for CUDA 12.9 or later checks callback registration, current log retrieval, and dumps to a temporary file and memory buffer.

Suggested reviewers: rwgk

Change: Bug fix

Merge Risk: Low · previous review 252f5

This change makes the CUDA 12.9 cuLogs APIs resolve at the correct version, with a regression test. The test registers a null callback and does not clean it up on failure, so it could crash the test process if the driver emits a log. Fix the test before merging; the production binding change itself looks sound.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

coderabbitai

Actionable comments posted: 2

Review info

Run configuration

Source mode: Auto

Repository: NVIDIA/cuda-python

Branch: main

File: .coderabbit.yaml

Commit: b3c5fb2

Layers: Repository YAML

Review profile: CHILL

Plan: Enterprise

Run ID: `208f3a5b-ed63-40cd-8886-4fbf99c0a66b`

Commits

Reviewing files that changed from the base of the PR and between `b3c5fb2` and `252f5c2`.

Files selected for processing: 3

`cuda_bindings_12/cuda/bindings/_internal/driver_linux.pyx`

`cuda_bindings_12/cuda/bindings/_internal/driver_windows.pyx`

`cuda_bindings_12/tests/test_cuda.py`

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

coderabbitai · 2026-11-05T20:40:05Z

+)
+def test_culogs_functions():
+    try:
+        err, callback_handle = cuda.cuLogsRegisterCallback(0, None)


Major · Stability & Availability · Quick win

Supported by static analysis

Script executed:

rg -n 'cuLogsCallbackWrapper|cuLogsRegisterCallback|cuLogsUnregisterCallback' cuda_bindings_12/cuda/bindings/driver.pyx sed -n '1155,1195p' cuda_bindings_12/tests/test_cuda.py

Repository: NVIDIA/cuda-python

Length of output: 2131

Script executed:

sed -n '50970,51060p' cuda_bindings_12/cuda/bindings/driver.pyx rg -n -F -e 'cuLogsRegisterCallback' -e 'cuLogsCallbackWrapper' -- cuda_bindings_12/cuda/bindings/driver.pyx || test "$?" -eq 1

Repository: NVIDIA/cuda-python

Length of output: 3871

important: Register a live callback, not None.

cuLogsRegisterCallback(0, None) stores a NULL user callback. The binding always registers cuLogsCallbackWrapper with the driver, and that wrapper calls the stored callback without a NULL check (cuda_bindings_12/cuda/bindings/driver.pyx:50976). If the driver delivers a log message while this callback is registered, the wrapper calls a NULL function pointer and can crash the test process.

Register a no-op callback instead:

Suggested fix

--- "a/cuda_bindings_12/tests/test_cuda.py" +++ "b/cuda_bindings_12/tests/test_cuda.py" @@ -1156,13 +1156,16 @@ assert state is None +def _noop_culogs_callback(user_data, log_level, message, length): + pass + @pytest.mark.skipif( driver_version_less_than(12090), reason="cuLogs* functions were introduced in CUDA 12.9", ) def test_culogs_functions(): try: - err, callback_handle = cuda.cuLogsRegisterCallback(0, None) + err, callback_handle = cuda.cuLogsRegisterCallback(_noop_culogs_callback, None) assert err == cuda.CUresult.CUDA_SUCCESS err, _ = cuda.cuLogsCurrent(0)

If the test case crashes we will catch that in CI. Adding no-op will make the test case complicated.

@lijinf2 important: Understood. I won’t press for the no-op callback. The reported crash risk depends on the driver delivering a log message, so CI can pass without exercising that path.

_{You are interacting with an AI system.}

coderabbitai · 2026-11-05T20:40:05Z

+        err, _, _ = cuda.cuLogsDumpToMemory(None, buf, len(buf), 0)
+        assert err == cuda.CUresult.CUDA_SUCCESS
+
+        (err,) = cuda.cuLogsUnregisterCallback(callback_handle)


Major · Stability & Availability · Quick win

important: Unregister the callback on failure.

If a later cuLogs call raises FunctionNotFoundError or an assertion fails, this line is skipped and the callback remains registered for subsequent tests. A subsequent log can then crash the process through the null callback. Unregister the callback in a finally block after successful registration. (raw.githubusercontent.com)

It's ok to crash because this is a test case not core code.

@lijinf2 suggestion: Understood. I will leave callback cleanup to your discretion. The concern is test isolation, not core-code safety.

_{You are interacting with an AI system.}

We want to match existing code on the 12.9.x branch in this PR. This isn't significant enough I think to track as a follow-on.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

rwgk · 2026-11-05T21:06:29Z

+        err, _, _ = cuda.cuLogsDumpToMemory(None, buf, len(buf), 0)
+        assert err == cuda.CUresult.CUDA_SUCCESS
+
+        (err,) = cuda.cuLogsUnregisterCallback(callback_handle)


We want to match existing code on the 12.9.x branch in this PR. This isn't significant enough I think to track as a follow-on.

rwgk · 2026-11-05T23:07:17Z

/ok to test 6ad46aa

github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Nov 5, 2026

lijinf2 self-assigned this Nov 5, 2026

lijinf2 added the bug Something isn't working label Nov 5, 2026

lijinf2 added this to the cuda.bindings 13.5.0 & 12.9.10 milestone Nov 5, 2026

coderabbitai Bot reviewed Nov 5, 2026

View reviewed changes

rwgk approved these changes Nov 5, 2026

View reviewed changes

rwgk enabled auto-merge (squash) November 5, 2026 21:07

Merge branch 'main' into cb12-2978-main

6ad46aa

rwgk merged commit 1b32c8c into NVIDIA:main Nov 5, 2026
26 of 28 checks passed

Conversation

lijinf2 commented Nov 5, 2026

Uh oh!

copy-pr-bot Bot commented Nov 5, 2026

Uh oh!

coderabbitai Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Summary by CodeRabbit

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lijinf2 Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lijinf2 Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk commented Nov 5, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Nov 5, 2026 •

edited

Loading

coderabbitai Bot Nov 5, 2026 •

edited

Loading

coderabbitai Bot Nov 5, 2026 •

edited

Loading