Repository navigation
Conversation
|
/ok to test 24eeaf5 |
|
Hi Mike, could you review this 12.9.x backport of #3308 (global callback map lock)? |
|
Did you generate this from cybind? Generated files should always be handled that way to avoid things getting out of sync. It doesn't look like it updated the hash at the top of the file. |
@mdboom It's not generated, for two reasons: (1) 12.9.x uses a Tempita template (runtime.pyx.in), and I'm not sure how cybind can still produce that; (2) regenerating changes far more lines than this PR does, which would make it hard to review. I updated the hash with |
|
/ok to test 86320d7 |
close #3282
Manual backport of #3308 to
12.9.x.The callback registry shared by
cuLogsRegisterCallbackandcuDeviceRegisterAsyncNotificationwas not thread-safe. This adds locking so concurrent register/unregister works correctly.