[mdboom]

After implementing #3360, I decided to audit our other disabled ruff lints.

C408 catches potential performance issues, so should be re-enabled. Dictionary literals have special bytecodes for their construction and may be constant-constructed if all of the keys and values are also immutable constants. dict() can not perform such guarantees (dict itself could be overridden).

None of the fixes here are on hot paths (they are mostly in test code), so I don't consider anything here a performance improvement, but having this lint turned on will help us find performance opportunities in the future.

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Style

  • Updated several test cases to use consistent dictionary literal formatting.
  • Adjusted linting rules for dictionary construction patterns.

• Tests

  • Test inputs and expected behavior remain unchanged.

The global Ruff configuration no longer ignores C408. Three mappings in tests and a helper now use dictionary literals instead of dict() calls. Their keys, values, and test expectations remain unchanged.

Changes: Ruff C408 cleanup

Layer / File(s)	Summary
Enable C408 and update mappings ruff.toml, cuda_core/tests/test_program_cache.py, cuda_core/tests/test_tensor_map.py, cuda_python_test_helpers/cuda_python_test_helpers/cython_cache.py	The global ignore list no longer suppresses C408. Three mappings use dictionary literals with unchanged contents and test expectations.

Suggested reviewers: cpcloud

Change: Other

Merge Risk: Minimal · up to fc8ec

No actionable risk remains; the cleanup is safe to merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuda-python
• Branch: main
• File: .coderabbit.yaml
• Commit: deb3d04
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 20b086f4-3501-462d-a7dc-62fff6f61cb3

Commits

Reviewing files that changed from the base of the PR and between deb3d04 and fc8ec8f.

Files selected for processing: 4

• cuda_core/tests/test_program_cache.py
• cuda_core/tests/test_tensor_map.py
• cuda_python_test_helpers/cuda_python_test_helpers/cython_cache.py
• ruff.toml

Files with no reviewable changes: 1

• ruff.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

[github-actions]

Doc Preview CI
🚀 View preview at https://nvidia.github.io/cuda-python/pr-preview/pr-3362/
https://nvidia.github.io/cuda-python/pr-preview/pr-3362/cuda-core/
https://nvidia.github.io/cuda-python/pr-preview/pr-3362/cuda-bindings/
https://nvidia.github.io/cuda-python/pr-preview/pr-3362/cuda-pathfinder/
Preview will be ready when the GitHub Pages deployment is complete.

[juenglin]

Good to know!