[rluo8]

Description

The two TestGeneratedSourceDirIsKeyed tests fail in coverage CI on both Linux and Windows (example run). They expect Cython's generated-source directory to be configuration-specific and absolute, but coverage builds intentionally set build_dir="." so generated sources can be packaged.

Set build_hooks.COMPILE_FOR_COVERAGE to False in each test, making their intended regular-build precondition explicit. This does not change build behavior or coverage instrumentation.

Validation

• Ran cuda_core/tests/test_build_hooks.py --noconftest on Windows with CUDA_PYTHON_COVERAGE=0 and =1: 101 passed, 33 skipped in each mode.
• Ruff check and format check passed.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Tests
  • Updated build-directory tests to run with coverage compilation disabled while continuing to verify CUDA version separation and directory paths.

Two tests disable coverage compilation before checking generated build-directory paths for CUDA 12 and 13. The tests verify directory separation and absolute-path anchoring.

Changes: Build directory tests

Layer / File(s)	Summary
Set coverage mode for directory checks cuda_core/tests/test_build_hooks.py	Both tests set COMPILE_FOR_COVERAGE to False before checking generated build directories. The checks still verify distinct CUDA-major directories and absolute-path anchoring.

Possibly related issues

• NVIDIA/cuda-python#3344: The issue reports the same two tests failing in coverage CI. This change sets coverage compilation to False in those tests.

Suggested reviewers: juenglin

Change: Other · Severity of issue fixed: Low

Merge Risk: Minimal · up to b02e4

This test-only change introduces no production behavior or material correctness risk.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuda-python
• Branch: main
• File: .coderabbit.yaml
• Commit: 4010017
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: d86811d3-c77a-4243-ae38-545f08fc1e10

Commits

Reviewing files that changed from the base of the PR and between 4e3d5a9 and b02e415.

Files selected for processing: 1

• cuda_core/tests/test_build_hooks.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

[github-actions]

Doc Preview CI
🚀 View preview at https://nvidia.github.io/cuda-python/pr-preview/pr-3354/
https://nvidia.github.io/cuda-python/pr-preview/pr-3354/cuda-core/
https://nvidia.github.io/cuda-python/pr-preview/pr-3354/cuda-bindings/
https://nvidia.github.io/cuda-python/pr-preview/pr-3354/cuda-pathfinder/
Preview will be ready when the GitHub Pages deployment is complete.