Skip to content

Remove obsolete downgrading of pytest - #3339

Merged
mdboom merged 1 commit into
NVIDIA:mainfrom
mdboom:update-pytest-versions
Nov 3, 2026
Merged

Remove obsolete downgrading of pytest#3339
mdboom merged 1 commit into
NVIDIA:mainfrom
mdboom:update-pytest-versions

Conversation

@mdboom

@mdboom mdboom commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

There was a temporary hack in here to avoid pytest 9.1 while cuda-core tests had incompatible content. We are beyond that now (fixed in #2212), so this should no longer necessary (and our agents should be less confused by the inconsistency).

@mdboom mdboom added this to the cuda.core next milestone Nov 3, 2026
@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Nov 3, 2026
@mdboom mdboom self-assigned this Nov 3, 2026
@mdboom mdboom added the cuda.core Everything related to the cuda.core module label Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Tests
    • Updated released-package test runs on Linux and Windows to use the available pytest version rather than requiring a version below 9.1.
    • Linux test runs now skip selected coverage cases for older package releases, based on release version.

The released cuda-core test workflows remove explicit pytest version pins. The Linux workflow also applies two version-gated test deselections for older releases.

Changes: Released cuda-core test workflows

Layer / File(s) Summary
Pytest setup and version-gated selection
.github/workflows/test-wheel-linux.yml, .github/workflows/test-wheel-windows.yml		 The Linux workflow removes the pytest pin and deselects NvlinkVersion wrapper coverage through version 1.0.1 and frozen CUresult table coverage through version 1.2.1. The Windows workflow removes its pytest pin. Newer Linux releases do not receive these deselections.

Suggested labels: CI/CD

Suggested reviewers: leofang

Change: Other

Merge Risk: Minimal · up to d3618

The released cuda-core test workflows appear ready to merge after normal checks; no actionable issue was found.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts ### CodeRabbit Verify
  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9b07a93 and d361818.

Files selected for processing: 2
  • .github/workflows/test-wheel-linux.yml
  • .github/workflows/test-wheel-windows.yml
Files with no reviewable changes: 2
  • .github/workflows/test-wheel-windows.yml
  • .github/workflows/test-wheel-linux.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@mdboom
mdboom enabled auto-merge (squash) November 3, 2026 19:18
@mdboom
mdboom merged commit cd2c9be into NVIDIA:main Nov 3, 2026
220 of 223 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 4, 2026
cuda-python-bot
Clean up PR preview folders for 7 closed/merged PRs
c65e763 
Removed preview folders for the following PRs:
- PR #3324
- PR #3334
- PR #3339
- PR #3340
- PR #3346
- PR #3347
- PR #3348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

Assignees

@mdboom mdboom

Labels

CI/CD CI/CD infrastructure cuda.core Everything related to the cuda.core module

Projects

None yet

Milestone

cuda.core next

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom @rwgk