Skip to content

[no-ci] Display the logs when driver installation fails - #3287

Merged
jpascucci-nv merged 1 commit into
NVIDIA:mainfrom
jpascucci-nv:log-nvidia-error
Oct 29, 2026
Merged

jpascucci-nv merged 1 commit into
NVIDIA:mainfrom
jpascucci-nv:log-nvidia-error

Conversation

@jpascucci-nv

Copy link
Copy Markdown
Contributor

Description

Print the nvidia installer and dkms build logs on failure.

Checklist

  • I have read the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Print the nvidia installer and dkms build logs on failure.
@jpascucci-nv
jpascucci-nv requested review from juenglin and rwgk October 29, 2026 19:44
@jpascucci-nv jpascucci-nv added the CI/CD CI/CD infrastructure label Oct 29, 2026
@jpascucci-nv jpascucci-nv added this to the cuda.core 1.3.0 milestone Oct 29, 2026
@jpascucci-nv jpascucci-nv self-assigned this Oct 29, 2026
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 14fedab and 6a0014a.

Files selected for processing: 1
  • ci/tools/install_gpu_driver.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • GPU driver installation failures in CI now include the installer’s exit status and available installer or build logs, making failure details easier to review.

The GPU driver installation script now reports a nonzero installer exit status, prints available NVIDIA installer and DKMS logs in GitHub Actions groups, and returns the original status.

Changes: GPU installer diagnostics

Layer / File(s) Summary
Installer failure reporting
ci/tools/install_gpu_driver.sh
When the NVIDIA installer exits nonzero, the script reports its status, prints available installer and DKMS logs in GitHub Actions groups, and returns the original status.

Suggested labels: CI/CD

Suggested reviewers: leofang

Priority: Low

Change: Feature

Merge Risk: Minimal · up to 6a001

The failure path safely reports available logs without changing the installer’s failure status.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR

@jpascucci-nv
jpascucci-nv enabled auto-merge (squash) October 29, 2026 21:07

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (no findings from codex).

@jpascucci-nv
jpascucci-nv merged commit 3cc4edb into NVIDIA:main Oct 29, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants