You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): print lychee failure URLs in the job log - #3240
When LYCHEE_REPORT_DIR forces --format json, the job log only printed the short permanent/transient summary (Lychee has permanent or unclassified link failures…). The failing URLs already lived in the markdown report / step summary, but not in the console.
Echo the final failure table (source, URL, status, details) after that message so broken links are visible without opening the uploaded report artifact.
When LYCHEE_REPORT_DIR forces --format json, the console only showed the
short permanent/transient summary. Echo the final failure table (source,
URL, status) so broken links are visible without opening the report
artifact. FixesNVIDIA#3204.
Reviewing files that changed from the base of the PR and between e2315ba and 03948b8.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Improvements
When link-check failures occur, CI output now includes the detailed failure table alongside the classification message, making failure details easier to review.
The Markdown report continues to include the failure details, with the final report rendered once and reused for the artifact.
When there are no failures, CI output retains its existing message or warning.
The finish function now prints detailed link failure information to the CI console and reuses the rendered report in the Markdown artifact. The test checks the console output for the failure classification, table header, and escaped URL.
Changes: Lychee failure reporting
Layer / File(s)
Summary
Render and verify failure details ci/tools/retry_lychee.py, ci/tools/tests/test_retry_lychee.py
finish renders the report once and prints it when failures are present. The test checks the captured output and retains assertions for no retry and the Markdown report.
Assessment against linked issues
Objective
Addressed
Explanation
Identify which links fail in the CI output [#3204]
✅
Suggested reviewers:rwgk
Change: Bug fix · Severity of issue fixed: Low
Merge Risk: Minimal · previous review bdfc2
The change is mergeable with no identified current-head risk.
Finishing Touches
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Reviewing files that changed from the base of the PR and between 590a8bf and bdfc2cf.
Files selected for processing: 2
ci/tools/retry_lychee.py
ci/tools/tests/test_retry_lychee.py
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Preview will be ready when the GitHub Pages deployment is complete.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdboom
left a comment
Summary
When
LYCHEE_REPORT_DIRforces--format json, the job log only printed the short permanent/transient summary (Lychee has permanent or unclassified link failures…). The failing URLs already lived in the markdown report / step summary, but not in the console.Echo the final failure table (source, URL, status, details) after that message so broken links are visible without opening the uploaded report artifact.
Fixes #3204.
Test plan
python3 -m pytest ci/tools/tests/test_retry_lychee.py(90 passed)