Skip to content

fix(tests): ignore inherited setgid when checking program-cache tmp mode #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy-Jost merged 3 commits into from
Oct 28, 2026
Merged

fix(tests): ignore inherited setgid when checking program-cache tmp mode #3224

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ffeed0
fix(tests): ignore inherited setgid when checking program-cache tmp mode
mangeshraut712 Oct 26, 2026
deb38c4
Merge branch 'main' into fix/program-cache-tmp-ignore-setgid
mangeshraut712 Oct 27, 2026
b564407
Merge branch 'main' into fix/program-cache-tmp-ignore-setgid
mangeshraut712 Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cuda_core/tests/test_program_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2534,15 +2534,19 @@ def test_program_cache_tmp_dir_created_owner_only(tmp_path):
"""``tmp`` stages in-flight compiled device code before the atomic rename into
``entries``, so it must be created owner-only (0o700) regardless of the inherited
umask. ``root``/``entries`` intentionally inherit the umask to keep deliberately
shared caches working (PR #2399 review), so only ``tmp`` is asserted."""
shared caches working (PR #2399 review), so only ``tmp`` is asserted.

Compare only the access bits (``& 0o777``). A setgid parent makes Linux inherit
``S_ISGID`` onto ``tmp``; that bit does not grant access and must not fail the
owner-only check (issue #3214)."""
import stat

from cuda.core.utils._program_cache._file_stream import FileStreamProgramCache

root = tmp_path / "pc"
FileStreamProgramCache(path=root)

mode = stat.S_IMODE(os.stat(root / "tmp").st_mode)
mode = stat.S_IMODE(os.stat(root / "tmp").st_mode) & 0o777
assert mode == 0o700, f"tmp has mode {oct(mode)}"


Expand All @@ -2563,7 +2567,7 @@ def test_program_cache_preexisting_shared_root_used_as_is(tmp_path):
FileStreamProgramCache(path=root)

assert stat.S_IMODE(os.stat(root).st_mode) == 0o777
assert stat.S_IMODE(os.stat(root / "tmp").st_mode) == 0o700
assert (stat.S_IMODE(os.stat(root / "tmp").st_mode) & 0o777) == 0o700


@pytest.mark.thread_unsafe(reason="monkeypatches the process-global NVVM fingerprint probe")
Expand Down
Loading