test: skip IPC peer access tests when IPC is unavailable#2092
Open
rluo8 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
cuda.core
Contributor
Author
|
leofang
added
triage
leofang
requested changes
May 15, 2026
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
I left a comment in the bug, I don't think this is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix bug 6176793
Problem:
FAILED memory_ipc\test_peer_access.py::TestPeerAccessNotPreservedOnImport::test_main - RuntimeError: IPC is not available on Windows
FAILED memory_ipc\test_peer_access.py::TestBufferPeerAccessAfterImport::test_main[True] - RuntimeError: IPC is not available on Windows
FAILED memory_ipc\test_peer_access.py::TestBufferPeerAccessAfterImport::test_main[False] - RuntimeError: IPC is not available on Windows
The three tests in
cuda_core/tests/memory_ipc/test_peer_access.pydepend on themempool_device_x2fixture, which only checks for two GPUs with mutual peer access — it does not check for IPC support.The fix is to add an
ipc_mempool_device_x2fixture incuda_core/tests/conftest.pythat composesmempool_device_x2with the same IPC-capability checks already used byipc_device.After the fix, the tests could be successfully skipped.
tests/memory_ipc/test_peer_access.py::TestPeerAccessNotPreservedOnImport::test_main SKIPPED (Device does not...)
tests/memory_ipc/test_peer_access.py::TestBufferPeerAccessAfterImport::test_main[True] SKIPPED (Device does ...)
tests/memory_ipc/test_peer_access.py::TestBufferPeerAccessAfterImport::test_main[False] SKIPPED (Device does...)