Repository navigation
Fix cuFFT discovery with older CMake CUDA finders. - #166
Merged
Merged
Conversation
Fall back to the matching NVHPC math_libs directory when FindCUDAToolkit does not provide CUDA::cufft. Preserve existing CUDA targets and resolve headers alongside the selected library. Report the selected cuFFT library in the dependency summary. Fixes #165 Signed-off-by: Josh Romero <joshr@nvidia.com>
romerojosh
force-pushed
the
fix-cufft-cmake
branch
from
October 15, 2026 16:34
99a2bf2 to
9e0388e
Compare
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165.
In PR #163, I made changes to the CMake build process to use more generic tooling for dependency discovery (e.g.
FindCUDAToolkit) instead of a CMake configuration file sourced from the NVHPC SDK. Turns out that older CMake versions can fail to find the cuFFT library within the NVHPC SDK directory layout, which was the source of the configure error in #165. Newer CMake versions have aFindCUDAToolkitthat is NVHPC directory structure aware.This PR adds custom search logic for CMake versions that fail to find cuFFT on their own.