Add bounds-checked roaring bitmap constructor - #831
Draft
PointKernel wants to merge 5 commits into
Draft
Conversation
mhaseeb123
reviewed
Aug 3, 2026
Comment on lines
66
to
68
| roaring_bitmap(cuda::std::byte const* bitmap, | ||
| Allocator const& alloc = {}, | ||
| cuda::stream_ref stream = cuda::stream_ref{cudaStream_t{nullptr}}); |
Contributor
There was a problem hiding this comment.
Let's deprecate this one until libcudf can switch over to the new constructor and then delete it once we are no longer using it?
Contributor
There was a problem hiding this comment.
Going to open a draft PR in cudf and temporarily point cuco to this PR until it merges
Member
Author
There was a problem hiding this comment.
we also need a rapids-cmake PR bumping the cuco version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
cuda::std::spanoverload tocuco::experimental::roaring_bitmapand validates serialized bitmap bounds before host-side metadata parsing, allocation, and device copies. The bounded parser validates 32-bit container metadata, offsets, and payload sizes, as well as 64-bit bucket counts and nested bitmaps.The existing pointer overload remains source-compatible and is documented as deprecated and unchecked.