Repository navigation
build: drop the unused jupyter-compare-view dependency - #304
Merged
Merged
Conversation
jupyter-compare-view 0.2.4 supports only Python < 3.13, so uv pip check fails in the Python 3.13 cu128-train environment (NVBug 6970501). Nothing in the repository uses the package; remove it from the train extra and relock with uv 0.11.29. No other locked version changes. Signed-off-by: Dinghao Yang <dinghaoy@nvidia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lfengad
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NVBug 6970501: in the locked
cu128-trainenvironment,uv pip checkfails becausejupyter-compare-view0.2.4 supports only Python < 3.13, while the CUDA groups require Python 3.13.Nothing in the repository imports or uses
jupyter-compare-view, so this removes it from thetrainextra instead of pinning a newer version.Changes
pyproject.toml: removejupyter-compare-viewfrom thetrainextra.uv.lock: regenerated with uv 0.11.29; the only change is the removal ofjupyter-compare-view(no other package changes version).ATTRIBUTIONS.mdstill lists the package; it is left for the next attribution regeneration.Testing
On Python 3.13.12 with uv 0.11.29, following the bug's reproduction steps:
uv lock --checkpasses.uv sync --locked --python 3.13 --group cu128-train --extra train --extra guardrailsucceeds.uv pip checkexits 0.🤖 Generated with Claude Code