Repository navigation
[CI] Replace the pytest<9.2 cap with pytest-benchmark>=5.3.1 - #12607
pylaterreur wants to merge 1 commit into
Conversation
NVIDIA#12313 capped pytest below 9.2 in the cuda.cccl.examples lanes because pytest 9.2.0 removed the private Function._nodeid, which pytest-benchmark 5.3.0 read in its benchmark fixture (ionelmc/pytest-benchmark#321). pytest-benchmark 5.3.1 reads the public nodeid instead, so require it and let pytest float again, as the TODO asked. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GwUvhmzgfkiZ6vo4uGyesN
|
No actionable comments were generated in the recent review. Summary
Change: Other Merge Risk:
|
Description
Follow-up to #12313.
#12313 capped pytest below 9.2 in the
cuda.cccl.exampleslanes: pytest 9.2.0 removed the privateFunction._nodeid, and pytest-benchmark 5.3.0 read it in itsbenchmarkfixture (ionelmc/pytest-benchmark#321), so every host-benchmark case errored during setup. pytest-benchmark 5.3.1 (2026-11-01, ionelmc/pytest-benchmark#323) reads the publicnodeidinstead.As the TODO in #12313 asks, this PR removes the pytest cap from the Linux and Windows install lines and requires
pytest-benchmark>=5.3.1.Checked locally on Python 3.14 (no GPU), with a parametrized test that uses the
benchmarkfixture under--benchmark-disable, as the smoke test does:AttributeError: 'Function' object has no attribute '_nodeid', as in the CI logspip install --dry-run pytest pytest-xdist "pytest-benchmark>=5.3.1"resolves to pytest 9.2.0, pytest-xdist 3.8.0 and pytest-benchmark 5.3.1.pre-commit run --filespasses on both scripts.Not verified: the
cuda.cccl.examplesCI lanes themselves.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01GwUvhmzgfkiZ6vo4uGyesN