Repository navigation
Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Public API and data contracts python/cuda_coop/cuda/coop/__init__.py*, python/cuda_coop/cuda/coop/_typing*, python/cuda_coop/cuda/coop/_core/api/*, python/cuda_coop/cuda/coop/_core/_types.py, python/cuda_coop/cuda/coop/_core/thread_group.py |
Removes package exports, load/store and storage APIs, thread-group declarations, payload protocols, and related type declarations. |
Group and load/store planning python/cuda_coop/cuda/coop/_core/* |
Removes specialization and binding utilities, launch and group models, group resolution, and block and warp load/store planning. |
Backend and header integration python/cuda_coop/cuda/coop/_headers/*, python/cuda_coop/cuda/coop/_registration.py, python/cuda_coop/cuda/coop/numba_mlir/* |
Removes backend registration and activation, compiler support, caching, descriptor processing, and header and toolkit resolution. |
Packaging and CI configuration python/cuda_coop/CMakeLists.txt, ci/*cuda_coop*, ci/matrix.yaml, ci/project_files_and_dependencies.yaml, ci/test/inspect_changes/*, .pre-commit-config.yaml, .vscode/launch.json |
Removes wheel build, validation, and test scripts and related CI entries. It updates license filtering and Ruff coverage and removes package-specific change-inspection fixtures and debugger configurations. |
Documentation and visualization removal docs/conf.py, docs/_ext/coop_visualization.py, docs/_static/coop-*, docs/python/coop*, docs/python/coop_api.rst, docs/python/api_reference.rst, docs/python/index.rst |
Removes cuda.coop guides, API references, examples, Sphinx hooks, and interactive load/store visualizations. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Pin pytest below 9.2 for cuda.cccl.examples CI jobs [#12313] |
❌ | No pytest version pin or cuda.cccl.examples CI change is present. |
| ### Out-of-scope changes | ||
| Code Change | Explanation | |
| :--- | :--- | |
| Not applicable | Issue #12313 is marked closed and historical context only, not a requirement for this pull request. |
Possibly related issues
- NVIDIA/cccl#12022 — The issue proposes a typed pipeline for the cuda.coop Numba-CUDA-MLIR backend. This pull request removes that backend rather than implementing the proposed pipeline.
Priority:
Change: Other
Merge Risk: 
Minimal · previous review b0e25
-
The removal is internally consistent, with no identified merge-blocking risk.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Actionable comments posted: 1

Review info
-
Run configuration-
- Source mode: Auto
- Repository: NVIDIA/cccl
- Branch: main
- File: .coderabbit.yaml
- Commit: 72c6a92
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
b360c2ef-f0c3-4ee6-99d3-a1e0b4448189
Files ignored due to path filters: 8-
docs/python/coop/visualizations/compiler-phases-classes-mobile.svgis excluded by!**/*.svgdocs/python/coop/visualizations/compiler-phases-classes.svgis excluded by!**/*.svgdocs/python/coop/visualizations/compiler-phases.svgis excluded by!**/*.svgdocs/python/coop/visualizations/compiler-swimlane-classes-mobile.svgis excluded by!**/*.svgdocs/python/coop/visualizations/compiler-swimlane-classes.svgis excluded by!**/*.svgdocs/python/coop/visualizations/compiler-swimlane.svgis excluded by!**/*.svgdocs/python/coop/visualizations/load-transpose.svgis excluded by!**/*.svgdocs/python/coop/visualizations/store-transpose.svgis excluded by!**/*.svg
Files selected for processing: 200-
.pre-commit-config.yaml.vscode/launch.jsonAGENTS.mdci/build_cuda_coop_python.shci/matrix.yamlci/project_files_and_dependencies.yamlci/test/inspect_changes/core_dirty.outputci/test/inspect_changes/cuda_coop_python.dirty_filesci/test/inspect_changes/cuda_coop_python.outputci/test/inspect_changes/cuda_coop_python_cudax.dirty_filesci/test/inspect_changes/cuda_coop_python_cudax.outputci/test/inspect_changes/cuda_coop_python_license.dirty_filesci/test/inspect_changes/cuda_coop_python_license.outputci/test/inspect_changes/cuda_coop_python_pyproject.dirty_filesci/test/inspect_changes/cuda_coop_python_pyproject.outputci/test/inspect_changes/cuda_coop_python_pyproject_near_miss.dirty_filesci/test/inspect_changes/cuda_coop_python_pyproject_near_miss.outputci/test/inspect_changes/cuda_coop_python_windows_ci.dirty_filesci/test/inspect_changes/cuda_coop_python_windows_ci.outputci/test/inspect_changes/ignored_only.dirty_filesci/test/inspect_changes/libcudacxx_both.outputci/test/inspect_changes/libcudacxx_public_only.outputci/test/inspect_changes/libcudacxx_thrust.outputci/test_cuda_coop_python.shci/validate_cuda_coop_wheel.pyci/windows/build_cuda_coop_python.ps1docs/_ext/coop_visualization.pydocs/_static/coop-api.cssdocs/_static/coop-explorer.jsdocs/_static/coop-load.cssdocs/_static/coop-load.jsdocs/_static/coop-movement.jsdocs/conf.pydocs/python/api_reference.rstdocs/python/coop.rstdocs/python/coop/concepts.rstdocs/python/coop/configuration.rstdocs/python/coop/debugger_walkthrough.pydocs/python/coop/developer_overview.rstdocs/python/coop/faqs.rstdocs/python/coop/glossary.rstdocs/python/coop/programming_guide.rstdocs/python/coop/source_dumps/direct.cpp.txtdocs/python/coop/source_dumps/transpose.cpp.txtdocs/python/coop/visualizations/index.rstdocs/python/coop/visualizations/load.rstdocs/python/coop/visualizations/store.rstdocs/python/coop_api.rstdocs/python/index.rstpython/cuda_coop/AGENTS.mdpython/cuda_coop/CMakeLists.txtpython/cuda_coop/LICENSEpython/cuda_coop/README.mdpython/cuda_coop/cuda/coop/__init__.pypython/cuda_coop/cuda/coop/__init__.pyipython/cuda_coop/cuda/coop/_core/__init__.pypython/cuda_coop/cuda/coop/_core/_adapter.pypython/cuda_coop/cuda/coop/_core/_algorithm.pypython/cuda_coop/cuda/coop/_core/_auto_registration.pypython/cuda_coop/cuda/coop/_core/_bindings.pypython/cuda_coop/cuda/coop/_core/_source_dump.pypython/cuda_coop/cuda/coop/_core/_symbols.pypython/cuda_coop/cuda/coop/_core/_types.pypython/cuda_coop/cuda/coop/_core/api/__init__.pypython/cuda_coop/cuda/coop/_core/api/__init__.pyipython/cuda_coop/cuda/coop/_core/api/_dispatch.pypython/cuda_coop/cuda/coop/_core/api/_payload.pypython/cuda_coop/cuda/coop/_core/api/load_store.pypython/cuda_coop/cuda/coop/_core/api/load_store.pyipython/cuda_coop/cuda/coop/_core/api/temp_storage.pypython/cuda_coop/cuda/coop/_core/api/temp_storage.pyipython/cuda_coop/cuda/coop/_core/api/thread_data.pypython/cuda_coop/cuda/coop/_core/api/thread_data.pyipython/cuda_coop/cuda/coop/_core/api/thread_group.pypython/cuda_coop/cuda/coop/_core/api/thread_group.pyipython/cuda_coop/cuda/coop/_core/block/__init__.pypython/cuda_coop/cuda/coop/_core/block/_common.pypython/cuda_coop/cuda/coop/_core/block/load_store.pypython/cuda_coop/cuda/coop/_core/dtype_policy.pypython/cuda_coop/cuda/coop/_core/group/__init__.pypython/cuda_coop/cuda/coop/_core/group/_dispatch.pypython/cuda_coop/cuda/coop/_core/group/_execution_requirements.pypython/cuda_coop/cuda/coop/_core/group/_model.pypython/cuda_coop/cuda/coop/_core/group/_resolution.pypython/cuda_coop/cuda/coop/_core/group/load_store.pypython/cuda_coop/cuda/coop/_core/launch.pypython/cuda_coop/cuda/coop/_core/thread_group.pypython/cuda_coop/cuda/coop/_core/warp/__init__.pypython/cuda_coop/cuda/coop/_core/warp/load_store.pypython/cuda_coop/cuda/coop/_headers/__init__.pypython/cuda_coop/cuda/coop/_headers/_identity.pypython/cuda_coop/cuda/coop/_headers/_toolkit.pypython/cuda_coop/cuda/coop/_registration.pypython/cuda_coop/cuda/coop/_typing.pypython/cuda_coop/cuda/coop/_typing.pyipython/cuda_coop/cuda/coop/numba_mlir/__init__.pypython/cuda_coop/cuda/coop/numba_mlir/__init__.pyipython/cuda_coop/cuda/coop/numba_mlir/_compiler/__init__.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_activation.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_artifacts.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_caching.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_descriptor_provenance.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_errors.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_load_store.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_planner.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_planner_support.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_planning.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_group_rewriting.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_layout.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_load_store_algorithms.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_numba_mlir_compat.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_nvrtc.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_operations.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_parameters.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_planner.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_arguments.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_group_metadata.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_invocables.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_launch.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_load_store.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_payload.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_provenance.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_storage.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_rewrite_support.pypython/cuda_coop/cuda/coop/numba_mlir/_compiler/_scalar_provenance.pypython/cuda_coop/cuda/coop/numba_mlir/_group/__init__.pypython/cuda_coop/cuda/coop/numba_mlir/_group/_load_store.pypython/cuda_coop/cuda/coop/numba_mlir/_group/_load_store.pyipython/cuda_coop/cuda/coop/numba_mlir/_group/_marker.pypython/cuda_coop/cuda/coop/numba_mlir/_lowering/__init__.pypython/cuda_coop/cuda/coop/numba_mlir/_lowering/_core.pypython/cuda_coop/cuda/coop/numba_mlir/_lowering/_load_store.pypython/cuda_coop/cuda/coop/numba_mlir/_semantic.pypython/cuda_coop/cuda/coop/numba_mlir/_temp_storage.pypython/cuda_coop/cuda/coop/numba_mlir/_temp_storage.pyipython/cuda_coop/cuda/coop/numba_mlir/_thread_data.pypython/cuda_coop/cuda/coop/numba_mlir/_thread_data.pyipython/cuda_coop/cuda/coop/numba_mlir/_thread_group.pypython/cuda_coop/cuda/coop/numba_mlir/_thread_group.pyipython/cuda_coop/cuda/coop/numba_mlir/_types.pypython/cuda_coop/cuda/coop/numba_mlir/py.typedpython/cuda_coop/cuda/coop/py.typedpython/cuda_coop/examples/numba_mlir/block_load.pypython/cuda_coop/examples/numba_mlir/block_store.pypython/cuda_coop/examples/numba_mlir/source_dumps.pypython/cuda_coop/pyproject.tomlpython/cuda_coop/tests/__init__.pypython/cuda_coop/tests/_group_planning.pypython/cuda_coop/tests/backends/numba_mlir/__init__.pypython/cuda_coop/tests/backends/numba_mlir/compile/__init__.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_block_load_store_compile.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_installed_activation_compile.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_load_store_target_compile.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_scalar_store_typing.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_storage_diagnostics.pypython/cuda_coop/tests/backends/numba_mlir/compile/test_warp_load_store_compile.pypython/cuda_coop/tests/backends/numba_mlir/runtime/__init__.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_block_load_store.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_device_helpers_example.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_load_example.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_programming_guide_examples.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_qualified_load_store_examples.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_storage_examples.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_store_example.pypython/cuda_coop/tests/backends/numba_mlir/runtime/test_warp_load_store.pypython/cuda_coop/tests/backends/numba_mlir/unit/__init__.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_caching.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_data_movement.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_family_registration.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_group_hierarchy.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_group_lowering_plan.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_invocable_identity.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_invocable_lifecycle.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_launch_dimension_rewrites.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_nvrtc.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_parameter_names.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_public_foundation.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_runtime_activation.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_storage_rewrites.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_thread_data.pypython/cuda_coop/tests/backends/numba_mlir/unit/test_thread_groups.pypython/cuda_coop/tests/packaging/test_typing.pypython/cuda_coop/tests/packaging/typing/common_consumer.pypython/cuda_coop/tests/packaging/typing/invalid_consumer.pypython/cuda_coop/tests/packaging/typing/numba_consumer.pypython/cuda_coop/tests/test_bindings.pypython/cuda_coop/tests/test_block_load_store.pypython/cuda_coop/tests/test_group_load_store.pypython/cuda_coop/tests/test_group_resolution.pypython/cuda_coop/tests/test_header_bundle.pypython/cuda_coop/tests/test_header_identity.pypython/cuda_coop/tests/test_headers.pypython/cuda_coop/tests/test_registration.pypython/cuda_coop/tests/test_source_dump.pypython/cuda_coop/tests/test_thread_group.pypython/cuda_coop/tests/test_toolkit.pypython/cuda_coop/tests/test_types.pypython/cuda_coop/tests/test_warp_load_store.pypython/cuda_coop/tests/typing/pyright-unused.json
Files with no reviewable changes: 95-
- python/cuda_coop/LICENSE
- ci/test/inspect_changes/cuda_coop_python_pyproject.output
- ci/test/inspect_changes/cuda_coop_python_license.dirty_files
- ci/test/inspect_changes/cuda_coop_python_pyproject_near_miss.dirty_files
- docs/python/coop/visualizations/index.rst
- docs/python/coop.rst
- docs/python/coop/visualizations/load.rst
- ci/test/inspect_changes/cuda_coop_python_license.output
- docs/_static/coop-api.css
- docs/_static/coop-load.css
- docs/python/coop/concepts.rst
- docs/python/coop/glossary.rst
- ci/test/inspect_changes/cuda_coop_python_windows_ci.output
- docs/python/coop/configuration.rst
- AGENTS.md
- python/cuda_coop/cuda/coop/_core/api/init.py
- ci/test/inspect_changes/cuda_coop_python_cudax.dirty_files
- docs/python/coop/programming_guide.rst
- ci/test/inspect_changes/cuda_coop_python_pyproject_near_miss.output
- python/cuda_coop/cuda/coop/numba_mlir/_compiler/init.py
- python/cuda_coop/cuda/coop/_core/warp/init.py
- ci/build_cuda_coop_python.sh
- python/cuda_coop/cuda/coop/_core/api/thread_group.pyi
- python/cuda_coop/README.md
- .vscode/launch.json
- ci/test/inspect_changes/cuda_coop_python_windows_ci.dirty_files
- ci/test/inspect_changes/cuda_coop_python_pyproject.dirty_files
- ci/test/inspect_changes/cuda_coop_python_cudax.output
- python/cuda_coop/cuda/coop/_core/api/thread_data.pyi
- python/cuda_coop/cuda/coop/_core/_symbols.py
- docs/python/index.rst
- docs/python/coop/faqs.rst
- ci/test/inspect_changes/cuda_coop_python.dirty_files
- docs/_static/coop-explorer.js
- python/cuda_coop/cuda/coop/_registration.py
- ci/test/inspect_changes/cuda_coop_python.output
- docs/python/api_reference.rst
- python/cuda_coop/cuda/coop/_headers/init.py
- docs/python/coop/developer_overview.rst
- ci/validate_cuda_coop_wheel.py
- python/cuda_coop/cuda/coop/_core/block/_common.py
- python/cuda_coop/cuda/coop/_core/_source_dump.py
- python/cuda_coop/cuda/coop/_core/block/load_store.py
- python/cuda_coop/cuda/coop/_core/_types.py
- python/cuda_coop/AGENTS.md
- ci/test/inspect_changes/ignored_only.dirty_files
- python/cuda_coop/cuda/coop/_core/api/temp_storage.pyi
- python/cuda_coop/cuda/coop/_core/group/_dispatch.py
- python/cuda_coop/cuda/coop/_core/block/init.py
- python/cuda_coop/cuda/coop/numba_mlir/_compiler/_descriptor_provenance.py
- docs/python/coop_api.rst
- python/cuda_coop/cuda/coop/_headers/_toolkit.py
- docs/python/coop/visualizations/store.rst
- python/cuda_coop/cuda/coop/_core/api/temp_storage.py
- python/cuda_coop/cuda/coop/_core/api/thread_data.py
- python/cuda_coop/cuda/coop/_core/_bindings.py
- .pre-commit-config.yaml
- python/cuda_coop/cuda/coop/numba_mlir/_compiler/_activation.py
- docs/_static/coop-load.js
- docs/_static/coop-movement.js
- docs/_ext/coop_visualization.py
- python/cuda_coop/cuda/coop/numba_mlir/_compiler/_artifacts.py
- python/cuda_coop/cuda/coop/_core/api/thread_group.py
- ci/test_cuda_coop_python.sh
- python/cuda_coop/CMakeLists.txt
- docs/python/coop/debugger_walkthrough.py
- python/cuda_coop/cuda/coop/_core/group/_resolution.py
- python/cuda_coop/cuda/coop/_core/group/load_store.py
- python/cuda_coop/cuda/coop/_core/api/_payload.py
- python/cuda_coop/cuda/coop/init.pyi
- python/cuda_coop/cuda/coop/numba_mlir/init.py
- python/cuda_coop/cuda/coop/_core/api/_dispatch.py
- python/cuda_coop/cuda/coop/_typing.pyi
- python/cuda_coop/cuda/coop/_core/api/load_store.py
- python/cuda_coop/cuda/coop/numba_mlir/_compiler/_caching.py
- python/cuda_coop/cuda/coop/_core/_algorithm.py
- ci/windows/build_cuda_coop_python.ps1
- python/cuda_coop/cuda/coop/_core/api/init.pyi
- python/cuda_coop/cuda/coop/_core/launch.py
- python/cuda_coop/cuda/coop/_core/group/_model.py
- python/cuda_coop/cuda/coop/_core/dtype_policy.py
- python/cuda_coop/cuda/coop/numba_mlir/init.pyi
- python/cuda_coop/cuda/coop/_typing.py
- docs/python/coop/source_dumps/transpose.cpp.txt
- docs/python/coop/source_dumps/direct.cpp.txt
- python/cuda_coop/cuda/coop/init.py
- python/cuda_coop/cuda/coop/_core/_auto_registration.py
- python/cuda_coop/cuda/coop/_core/thread_group.py
- python/cuda_coop/cuda/coop/_core/group/_execution_requirements.py
- python/cuda_coop/cuda/coop/_core/group/init.py
- python/cuda_coop/cuda/coop/_headers/_identity.py
- python/cuda_coop/cuda/coop/_core/init.py
- python/cuda_coop/cuda/coop/_core/api/load_store.pyi
- python/cuda_coop/cuda/coop/_core/warp/load_store.py
- python/cuda_coop/cuda/coop/_core/_adapter.py
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
-
This comment has been minimized.
This comment has been minimized.
b101d0a to
b0e25a9
Compare
|
@coderabbitai full review |
✅ Action performed
|
This comment has been minimized.
This comment has been minimized.
Prepare for a CUTLASS-focused first release by removing the shared foundation and Numba-CUDA-MLIR backend. Remove their packaging, tests, documentation, CI jobs, and editor configuration together. Signed-off-by: Trent Nelson <trent@trent.me>
Match the remaining root and C++ license paths explicitly after removing the cooperative package. Preserve Python package license coverage. Signed-off-by: Trent Nelson <trent@trent.me>
b0e25a9 to
1ff5275
Compare
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 4h 27m: Pass: 100%/483 | Total: 19d 12h | Max: 4h 00m | Hits: 44%/2393364See results here. |
This removes the existing
python/cuda_cooppackage, including the shared foundation from #11182 and the Numba-CUDA-MLIR backend from #11200, plus their documentation, build scripts, CI jobs, editor configuration, and package guidance from #11752. This clears the existing implementation for the standalone CUTLASS work in #12311.Existing
cuda.computeand STF functionality is unchanged. The rebase preserves the newer Windows CUDA 12.0 CI configuration frommain.Validation
main.sccachestartup timeout. The previously failing STF two-GPUtest_numba_placescase also passes on this head.No package runtime tests remain after this removal.