Polygraphy - fix POLYGRAPHY_ASK_BEFORE_INSTALL=0 still enabling the install prompt

[VaggelisGian]

What does this PR do?

POLYGRAPHY_ASK_BEFORE_INSTALL could not be disabled. In tools/Polygraphy/polygraphy/config.py, the flag was parsed as:

ASK_BEFORE_INSTALL = bool(os.environ.get("POLYGRAPHY_ASK_BEFORE_INSTALL", "0" != "0"))

The default argument is the boolean expression "0" != "0" (evaluates to False), instead of the string "0". Because bool("0") is True, any value present in the environment - including 0 - enabled the install prompt, and there was no way to turn it off.

The fix moves the comparison outside the call, matching the idiom used by the sibling flags in the same file:

ASK_BEFORE_INSTALL = bool(os.environ.get("POLYGRAPHY_ASK_BEFORE_INSTALL", "0") != "0")

Testing

New test module tests/test_config.py::TestConfigEnvVars::test_ask_before_install, covering unset, 0 and 1 values via importlib.reload with environment restore.

Commands and output on this machine (after the fix):

$ cd tools/Polygraphy
$ python -m pytest tests/test_config.py -v

tests\test_config.py::TestConfigEnvVars::test_ask_before_install PASSED   [100%]
======================== 1 passed, 1 warning in 0.03s ========================

Before the fix the test fails: with POLYGRAPHY_ASK_BEFORE_INSTALL=0 in the environment the reloaded config reports ASK_BEFORE_INSTALL == True. The single warning in the output (Marks applied to fixtures have no effect, from tests/conftest.py) is pre-existing on main and unrelated.

Environment

TensorRT OSS main (10d15ae), polygraphy sources run from the repo.
Python 3.12, tensorrt 11.2.1.2 (pip wheel), polygraphy 0.53.4,
NVIDIA RTX 5060 Ti, driver 591.86, Windows 11 Pro.

Issue

Per CONTRIBUTING.md, bugfixes start as an issue approved by TensorRT engineers before code review. I could not find an existing issue covering this; happy to file one and link it here if maintainers prefer that flow, or please advise whether this PR can proceed directly.

[VaggelisGian]

Thanks for the quick review and approval! Good to know it is also fixed internally for the next release - if you would rather take that one and close this PR, that works fine on my end. Either way is fine.

[pranavm-nvidia]

Thanks for the quick review and approval! Good to know it is also fixed internally for the next release - if you would rather take that one and close this PR, that works fine on my end. Either way is fine.

@VaggelisGian the fix is the same, but I like your test better. We can merge your PR and I'll integrate it with the internal changes.

[VaggelisGian]

Note on the failing check: build-ubuntu2004 fails with

open ubuntu-20.04.Dockerfile: no such file or directory

That Dockerfile no longer exists anywhere in the repository (removed on main back in the 10.13.2 release), so this step cannot succeed against any current tree. The failure predates this PR and is unrelated to the change, which only touches tools/Polygraphy.