Skip to content

[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an… - #17345

Open
xinhe-nv wants to merge 4 commits into
NVIDIA:mainfrom
xinhe-nv:prune
Open

[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an…#17345
xinhe-nv wants to merge 4 commits into
NVIDIA:mainfrom
xinhe-nv:prune

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

…d kanana-1.5-2.1b-instruct-2505 tests

Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models.

Dev Engineer Review

  • Removed Bielik-11B-v2.2-Instruct test, performance, model path, and multi-LoRA references.
  • Removed Kanana accuracy references, test entries, and waiver entry.
  • Configuration and test-list changes match the removal scope.
  • No production-code or API changes are included.

QA Engineer Review

  • Removed TestKanana_Instruct::test_auto_dtype.
  • Removed its entries from qa/llm_function_core.txt and waives.txt.
  • Removed test_bielik_11b_v2_2_instruct_multi_lora.
  • Removed the Bielik performance entry from test-db/l0_perf.yml.
  • Removed the Bielik model path registration.
  • The Kanana test was covered in the QA test list.
  • The Bielik multi-LoRA test was not listed in the modified integration test lists.
  • Verdict: sufficient.

Description

The background is https://docs.google.com/spreadsheets/d/17qLRr5oQESqn1rT9LrIUnpjvhH8wcC59273YEPT9k44/edit?gid=177162358#gid=177162358

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…d kanana-1.5-2.1b-instruct-2505 tests

Remove all test cases, test list entries, model path registrations, accuracy
references, and waives for these two models.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv enabled auto-merge (squash) August 6, 2026 06:52
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a76f324-a7c5-42a5-b971-89ef44ce9a7d

📥 Commits

Reviewing files that changed from the base of the PR and between d9bc9b6 and 7300624.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The PR removes Kanana accuracy coverage and Bielik model-path, performance, and multi-LoRA test coverage from integration and unit test definitions.

Changes

Model test coverage removal

Layer / File(s) Summary
Kanana accuracy coverage removal
tests/integration/defs/accuracy/references/*.yaml, tests/integration/defs/accuracy/test_llm_api_pytorch.py, tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/waives.txt
Removes Kanana GSM8K and MMLU references, the PyTorch accuracy test, its test-list entry, and its waiver entry.
Bielik test coverage removal
tests/integration/defs/perf/_model_paths.py, tests/integration/test_lists/test-db/l0_perf.yml, tests/unittest/llmapi/test_llm_pytorch.py
Removes the Bielik model path, L40S performance configuration, and multi-LoRA unit test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: crazydemo, tburt-nv, qijune

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes removal of the Bielik tests, which is a substantial part of the pull request, but it omits the Kanana test removals.
Description check ✅ Passed The description explains the removal scope and provides background, but it does not list test coverage or complete the checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@xinhe-nv

xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64254 [ run ] triggered by Bot. Commit: d9bc9b6 Link to invocation

task.evaluate(llm)


class TestKanana_Instruct(LlmapiAccuracyTestHarness):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestKanana_Instruct is the only coverage for an in-flight product fix. #14707 (open) fixes the very bug this test is waived under — nvbugs/6209806 — by relaxing transformers 5.x LlamaConfig.validate_architecture in _torch/pyexecutor/config_utils.py and tokenizer/tokenizer.py so models with an explicit head_dim load. It removes this exact waives.txt line to re-enable this test, and ships no replacement test of its own.

So if this lands first, that fix merges with zero regression coverage for the load path it changes.

Fine either way once it's a decision rather than a side effect — if kanana is genuinely retired, say so on #14707 so it gets a focused config_utils unit test instead; if it isn't, keep this class and let #14707 do the unwaive. The waives.txt overlap itself is not a problem (three-way merge is clean).

Everything else here checks out: no dangling references left for either model, check_test_list.py --validate passes, the bielik_11b_v2.2_instruct alias is removed from _model_paths.py too (a real retirement, not just a coverage drop), and no import in test_llm_pytorch.py is orphaned.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BowenFu should we keep this model or not?

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64254 [ run ] completed with state FAILURE. Commit: d9bc9b6
/LLM/main/L0_MergeRequest_PR pipeline #52159 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@xinhe-nv

xinhe-nv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64338 [ run ] triggered by Bot. Commit: 7300624 Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants