[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an… - #17345
[TRTLLM-15076][test] Remove Bielik-11B-v2.2-Instruct an…#17345xinhe-nv wants to merge 4 commits into
Conversation
…d kanana-1.5-2.1b-instruct-2505 tests Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR removes Kanana accuracy coverage and Bielik model-path, performance, and multi-LoRA test coverage from integration and unit test definitions. ChangesModel test coverage removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #64254 [ run ] triggered by Bot. Commit: |
| task.evaluate(llm) | ||
|
|
||
|
|
||
| class TestKanana_Instruct(LlmapiAccuracyTestHarness): |
There was a problem hiding this comment.
TestKanana_Instruct is the only coverage for an in-flight product fix. #14707 (open) fixes the very bug this test is waived under — nvbugs/6209806 — by relaxing transformers 5.x LlamaConfig.validate_architecture in _torch/pyexecutor/config_utils.py and tokenizer/tokenizer.py so models with an explicit head_dim load. It removes this exact waives.txt line to re-enable this test, and ships no replacement test of its own.
So if this lands first, that fix merges with zero regression coverage for the load path it changes.
Fine either way once it's a decision rather than a side effect — if kanana is genuinely retired, say so on #14707 so it gets a focused config_utils unit test instead; if it isn't, keep this class and let #14707 do the unwaive. The waives.txt overlap itself is not a problem (three-way merge is clean).
Everything else here checks out: no dangling references left for either model, check_test_list.py --validate passes, the bielik_11b_v2.2_instruct alias is removed from _model_paths.py too (a real retirement, not just a coverage drop), and no import in test_llm_pytorch.py is orphaned.
There was a problem hiding this comment.
@BowenFu should we keep this model or not?
|
PR_Github #64254 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #64338 [ run ] triggered by Bot. Commit: |
…d kanana-1.5-2.1b-instruct-2505 tests
Remove all test cases, test list entries, model path registrations, accuracy references, and waives for these two models.
Dev Engineer Review
QA Engineer Review
TestKanana_Instruct::test_auto_dtype.qa/llm_function_core.txtandwaives.txt.test_bielik_11b_v2_2_instruct_multi_lora.test-db/l0_perf.yml.Description
The background is https://docs.google.com/spreadsheets/d/17qLRr5oQESqn1rT9LrIUnpjvhH8wcC59273YEPT9k44/edit?gid=177162358#gid=177162358
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.