[None][test] default the disagg cache-transceiver precheck to off - #17337
Conversation
The precheck is a launch-script gate, not a pytest case, so it cannot be waived in waives.txt. Flip the default to opt-in until the gate is validated on the post-merge stages; per-test yaml enabled: true or TRTLLM_DISAGG_CT_PRECHECK=1 turn it on. Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
WalkthroughThe cache-transceiver precheck is disabled by default. YAML can enable it with ChangesCache transceiver precheck opt-in
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/scripts/perf-sanity/cache_transceiver_precheck/README.md`:
- Around line 29-37: Add the standard NVIDIA copyright header at the beginning
of the modified README, before the existing title, and set its copyright year to
the latest meaningful modification year.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 92a33b94-5c7c-4886-86a7-4040e5bd6d7b
📒 Files selected for processing (3)
tests/scripts/perf-sanity/cache_transceiver_precheck/README.mdtests/scripts/perf-sanity/cache_transceiver_precheck/precheck_config.pytests/unittest/others/test_cache_transceiver_precheck_config.py
|
/bot skip --comment "waive some test" |
|
PR_Github #64206 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64206 [ skip ] completed with state |
Description
Waive the disaggregated perf-sanity cache-transceiver precheck by flipping its default to opt-in, until the gate is validated on the post-merge stages.
The precheck is a launch-script gate (
slurm_ct_precheck_gate.sh, driven byctPrecheckEnabled), not a pytest case, so it cannot be waived viatests/integration/test_lists/waives.txt— this default flip is the waive. None of the 90 disagg perf-sanity yamls setcache_transceiver_precheck, so with this change the precheck is disabled on every stage and the real tests run unaffected.Re-enabling paths:
cache_transceiver_precheck: enabled: true(pilot a config)TRTLLM_DISAGG_CT_PRECHECK=1(env overrides yaml either way)Test Coverage
tests/unittest/others/test_cache_transceiver_precheck_config.py(32 passed): added an assertion that an empty config resolves toctPrecheckEnabled=0; explicit yaml opt-in and the env kill-switch behavior are unchanged and still covered.PR Checklist
🤖 Generated with Claude Code
Dev Engineer Review
ctPrecheckEnabledto default to0.cache_transceiver_precheck.enabled: true.TRTLLM_DISAGG_CT_PRECHECKenvironment-variable overrides.QA Engineer Review
tests/unittest/others/test_cache_transceiver_precheck_config.py.tests/integration/test_lists/,test-db/, orqa/were modified.