[https://nvbugs/6506920][fix] Recover DSpark E2E coverage - #17310
[https://nvbugs/6506920][fix] Recover DSpark E2E coverage#17310longlee0622 wants to merge 3 commits into
Conversation
Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe DeepSeek-V4-Pro DSpark GSM8K accuracy floor changed from ChangesDeepSeek GSM8K validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disbale-fail-fast |
|
PR_Github #64024 Bot args parsing error: usage: /bot [-h] |
|
/bot run --disable-fail-fast |
|
PR_Github #64028 [ run ] triggered by Bot. Commit: |
|
PR_Github #64028 [ run ] completed with state
|
There was a problem hiding this comment.
I mostly see driver/hardware issues in the test history, and only one accuracy-related failure. Somehow I don't see the same issue on other tests at the same time, so I wonder if this test exercises the driver in a unique way. We should keep an eye on this test after unwaiving it for a while in case that intermittent driver issue is still present.
|
/bot run --disable-fail-fast |
|
PR_Github #64212 [ run ] triggered by Bot. Commit: |
Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run --disable-fail-fast |
|
PR_Github #64212 [ run ] completed with state
|
|
PR_Github #64280 [ run ] triggered by Bot. Commit: |
Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #64326 [ run ] triggered by Bot. Commit: |
|
PR_Github #64280 [ run ] completed with state |
|
PR_Github #64326 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #64340 [ run ] triggered by Bot. Commit: |
Dev Engineer Review
96.0to95.9.test_gsm8k_dep8_megamoe_deepgemm.QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.Verdict: needs follow-up
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.