[None][chore] Update flashinfer-python from 0.6.15 to 0.6.16 - #17175
[None][chore] Update flashinfer-python from 0.6.15 to 0.6.16#17175nv-guomingz wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe pull request updates ChangesFlashInfer version update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@security_scanning/pyproject.toml`:
- Line 57: Regenerate security_scanning/poetry.lock from the flashinfer-python
0.6.16 requirement declared in pyproject.toml, ensuring the lockfile resolves
0.6.16 before installation or security scanning.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7d1ea504-9d1e-425a-9c4f-1c2d06985ee6
📒 Files selected for processing (3)
ATTRIBUTIONS-Python.mdrequirements.txtsecurity_scanning/pyproject.toml
28a9afd to
668f13f
Compare
|
/bot run |
|
PR_Github #63349 [ run ] triggered by Bot. Commit: |
|
PR_Github #63349 [ run ] completed with state
|
|
L0 is red on
Unrelated but useful for #17165, which works around the |
|
Thanks @BowenFu — addressed the first two, and I dug into the L0 failure; it turns out to be unrelated to the lock change. 1. Description mismatch — fixed. Updated the PR description: 2. 3. Actual L0 failure — pre-existing
Re #17165: thanks for the |
|
/bot run |
668f13f to
7977538
Compare
|
PR_Github #63404 [ run ] triggered by Bot. Commit: |
|
Both points check out — thanks for digging in. Confirmed the One correction on the plan though: rebasing will not clear the red. Nothing else from me on the diff — held only on CI. |
|
PR_Github #63404 [ run ] completed with state
|
|
/bot run |
7977538 to
4deb2e0
Compare
|
/bot run |
|
PR_Github #63424 [ run ] triggered by Bot. Commit: |
|
PR_Github #63425 [ run ] triggered by Bot. Commit: |
|
PR_Github #63424 [ run ] completed with state |
|
PR_Github #63425 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #63728 [ run ] triggered by Bot. Commit: |
|
PR_Github #63728 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #63795 [ run ] triggered by Bot. Commit: |
|
PR_Github #63795 [ run ] completed with state
|
c5dd39a to
3848242
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #63874 [ run ] triggered by Bot. Commit: |
|
PR_Github #63874 [ run ] completed with state
|
|
We don't need change the |
|
/bot run --disable-fail-fast |
|
PR_Github #63949 [ run ] triggered by Bot. Commit: |
Thanks @yihwang-nv , I updated it via bot per #17175 (comment) What are the guidelines for updating the security_scanning/poetry.lock file? If we leave it as is, could it trigger any security scan issues? |
|
PR_Github #63949 [ run ] completed with state
|
Bump flashinfer-python dependency to the latest stable release. Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
3848242 to
d53c44a
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #63975 [ run ] triggered by Bot. Commit: |
|
Flagging that the scope grew after the existing approvals: The change itself is well-reasoned and the containment is the right one — a module-scope What I think needs to be stated in the description, though, is that this makes the bump non-neutral on a supported configuration. Two things that would close it:
Not blocking, and I'm not asking for the workaround to be removed — the containment is correct. But a MoE communication path going away on 3.10/3.11 shouldn't be discoverable only by reading the diff of a version bump. |
Summary
requirements.txt,security_scanning/pyproject.toml, andATTRIBUTIONS-Python.md.security_scanning/poetry.lockviapoetry lock(poetry check --lockpasses): the flashinfer-python entry (version + wheel/sdist sha256 hashes) andmetadata.content-hash.[package.dependencies]block:nvidia-cudnn-frontend >=1.13.0 -> >=1.25.0. This is exactly flashinfer 0.6.16'srequires_dist(0.6.15 declared>=1.13.0). It is metadata only: the locked nvidia-cudnn-frontend package version is unchanged at 1.26.0, which satisfies both, so no package is upgraded/downgraded. Notesecurity_scanning/poetry.lockis not consumed by the L0 test pipeline (it feeds the separate security-scan / PLC job), so it is not a candidate cause of an L0 test failure.Test plan
pip install -r requirements.txtinstalls successfullyDev Engineer Review
flashinfer-pythonfrom0.6.15to0.6.16.security_scanning/poetry.lockwith refreshed FlashInfer hashes and metadata.nvidia-cudnn-frontendconstraint. The locked version remains1.26.0.waives.txtfailures are pre-existing base-branch infrastructure issues.QA Engineer Review
No test changes.